Skip to content

[SPARK-57774][CORE] DriverLogger should not propagate log4j internal exception to caller #56890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 2 commits into from
Closed

[SPARK-57774][CORE] DriverLogger should not propagate log4j internal exception to caller #56890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786a8bf
[SPARK-57774][CORE] DriverLogger should ignore log4j internal exception
pan3793 Jun 30, 2026
54b9715
nit
pan3793 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ private[spark] class DriverLogger(conf: SparkConf) extends Logging {
builder.setBufferedIo(false)
builder.setConfiguration(config)
builder.withFileName(localLogFile)
builder.setIgnoreExceptions(false)
// SPARK-57774: Set to true to avoid propagating log4j internal exception
// (e.g., due to log4j bugs) to the caller.
builder.setIgnoreExceptions(true)

@uros-b uros-b Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a trade-off. With true here, a real failure to write the local driver log (disk full, permission loss mid-run) is now silently handled by log4j's internal error handler rather than surfacing.

@pan3793 pan3793 Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have any logic to handle exceptions thrown by logging calls, if users really care about that, maybe they should customize log4j's internal error handler?

builder.setLayout(layout)
builder.setName(DriverLogger.APPENDER_NAME)
builder.build()
Expand Down