[SPARK-57577][SQL] Surface timestamp constructor overflow as Spark error condition#56906
Draft
michaelmitchell-bit wants to merge 1 commit into
Draft
Conversation
cafd05e to
e0308aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR routes timestamp constructor overflow through
DATETIME_OVERFLOWinstead of rawArithmeticExceptionfor overflowingtimestamp_secondsandtimestamp_millisinputs.It adds a shared
QueryExecutionErrorshelper for timestamp constructor overflow, uses it from interpreted and code-generated expression paths, and keeps the existing non-overflow decimal rounding behavior unchanged.timestamp_microsalready accepts microseconds directly and has no unit-scaling overflow path, so this PR preserves its existing max/min input behavior.Why are the changes needed?
The existing overflow paths can surface raw Java arithmetic errors such as
long overfloworOverflow, which do not carry a Spark error condition or SQLSTATE. These timestamp constructor overflow cases should report a Spark error condition, consistent with other datetime overflow handling.Does this PR introduce any user-facing change?
Yes. Overflowing
timestamp_secondsandtimestamp_millisinputs now fail withDATETIME_OVERFLOW/ SQLSTATE22008instead of a rawArithmeticException.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex