[SPARK-57790][BUILD] Remove LICENSE-machinist.txt from licenses-binary#56912
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-57790][BUILD] Remove LICENSE-machinist.txt from licenses-binary#56912dongjoon-hyun wants to merge 1 commit into
LICENSE-machinist.txt from licenses-binary#56912dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
cc @huaxingao since this is a LICENSE fix although this is not a blocker. |
huaxingao
approved these changes
Jun 30, 2026
Member
Author
|
Thank you, @huaxingao ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 30, 2026
…nary` ### What changes were proposed in this pull request? This PR removes the orphaned `licenses-binary/LICENSE-machinist.txt` file. ### Why are the changes needed? `org.typelevel:machinist` was a macro dependency of older Spire versions. Since Spire 0.18 (`spire_2.13:0.18.0`), `machinist` is gone (merged into `spire`) and no longer bundled in the Spark binary distribution. - https://github.com/typelevel/machinist (Public Archived) - https://github.com/typelevel/spire (including `machinist`) - typelevel/spire#910 (2020-07-13) Apache Spark has `LICENSE-spire.txt` correctly. - https://github.com/apache/spark/blob/master/licenses-binary/LICENSE-spire.txt `machinist` jar is absent from `dev/deps/spark-deps-hadoop-3-hive-2.3` and from `build/sbt mllib-local/dependencyTree mllib/dependencyTree`, and is not referenced in `LICENSE-binary` or `NOTICE-binary`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. Verified `machinist` is no longer a bundled dependency via the dependency manifest and `dependencyTree`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56912 from dongjoon-hyun/SPARK-57790. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 06fa637) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 30, 2026
…nary` ### What changes were proposed in this pull request? This PR removes the orphaned `licenses-binary/LICENSE-machinist.txt` file. ### Why are the changes needed? `org.typelevel:machinist` was a macro dependency of older Spire versions. Since Spire 0.18 (`spire_2.13:0.18.0`), `machinist` is gone (merged into `spire`) and no longer bundled in the Spark binary distribution. - https://github.com/typelevel/machinist (Public Archived) - https://github.com/typelevel/spire (including `machinist`) - typelevel/spire#910 (2020-07-13) Apache Spark has `LICENSE-spire.txt` correctly. - https://github.com/apache/spark/blob/master/licenses-binary/LICENSE-spire.txt `machinist` jar is absent from `dev/deps/spark-deps-hadoop-3-hive-2.3` and from `build/sbt mllib-local/dependencyTree mllib/dependencyTree`, and is not referenced in `LICENSE-binary` or `NOTICE-binary`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. Verified `machinist` is no longer a bundled dependency via the dependency manifest and `dependencyTree`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56912 from dongjoon-hyun/SPARK-57790. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 06fa637) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 30, 2026
…nary` ### What changes were proposed in this pull request? This PR removes the orphaned `licenses-binary/LICENSE-machinist.txt` file. ### Why are the changes needed? `org.typelevel:machinist` was a macro dependency of older Spire versions. Since Spire 0.18 (`spire_2.13:0.18.0`), `machinist` is gone (merged into `spire`) and no longer bundled in the Spark binary distribution. - https://github.com/typelevel/machinist (Public Archived) - https://github.com/typelevel/spire (including `machinist`) - typelevel/spire#910 (2020-07-13) Apache Spark has `LICENSE-spire.txt` correctly. - https://github.com/apache/spark/blob/master/licenses-binary/LICENSE-spire.txt `machinist` jar is absent from `dev/deps/spark-deps-hadoop-3-hive-2.3` and from `build/sbt mllib-local/dependencyTree mllib/dependencyTree`, and is not referenced in `LICENSE-binary` or `NOTICE-binary`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. Verified `machinist` is no longer a bundled dependency via the dependency manifest and `dependencyTree`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56912 from dongjoon-hyun/SPARK-57790. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 06fa637) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 30, 2026
…nary` ### What changes were proposed in this pull request? This PR removes the orphaned `licenses-binary/LICENSE-machinist.txt` file. ### Why are the changes needed? `org.typelevel:machinist` was a macro dependency of older Spire versions. Since Spire 0.18 (`spire_2.13:0.18.0`), `machinist` is gone (merged into `spire`) and no longer bundled in the Spark binary distribution. - https://github.com/typelevel/machinist (Public Archived) - https://github.com/typelevel/spire (including `machinist`) - typelevel/spire#910 (2020-07-13) Apache Spark has `LICENSE-spire.txt` correctly. - https://github.com/apache/spark/blob/master/licenses-binary/LICENSE-spire.txt `machinist` jar is absent from `dev/deps/spark-deps-hadoop-3-hive-2.3` and from `build/sbt mllib-local/dependencyTree mllib/dependencyTree`, and is not referenced in `LICENSE-binary` or `NOTICE-binary`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. Verified `machinist` is no longer a bundled dependency via the dependency manifest and `dependencyTree`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56912 from dongjoon-hyun/SPARK-57790. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 06fa637) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 30, 2026
…nary` ### What changes were proposed in this pull request? This PR removes the orphaned `licenses-binary/LICENSE-machinist.txt` file. ### Why are the changes needed? `org.typelevel:machinist` was a macro dependency of older Spire versions. Since Spire 0.18 (`spire_2.13:0.18.0`), `machinist` is gone (merged into `spire`) and no longer bundled in the Spark binary distribution. - https://github.com/typelevel/machinist (Public Archived) - https://github.com/typelevel/spire (including `machinist`) - typelevel/spire#910 (2020-07-13) Apache Spark has `LICENSE-spire.txt` correctly. - https://github.com/apache/spark/blob/master/licenses-binary/LICENSE-spire.txt `machinist` jar is absent from `dev/deps/spark-deps-hadoop-3-hive-2.3` and from `build/sbt mllib-local/dependencyTree mllib/dependencyTree`, and is not referenced in `LICENSE-binary` or `NOTICE-binary`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. Verified `machinist` is no longer a bundled dependency via the dependency manifest and `dependencyTree`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56912 from dongjoon-hyun/SPARK-57790. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 06fa637) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to master/4.x/4.2/4.1/4.0/3.5 because this is a LICENSE bug fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the orphaned
licenses-binary/LICENSE-machinist.txtfile.Why are the changes needed?
org.typelevel:machinistwas a macro dependency of older Spire versions. Since Spire 0.18 (spire_2.13:0.18.0),machinistis gone (merged intospire) and no longer bundled in the Spark binary distribution.machinist)Apache Spark has
LICENSE-spire.txtcorrectly.machinistjar is absent fromdev/deps/spark-deps-hadoop-3-hive-2.3and frombuild/sbt mllib-local/dependencyTree mllib/dependencyTree, and is not referenced inLICENSE-binaryorNOTICE-binary.Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A. Verified
machinistis no longer a bundled dependency via the dependency manifest anddependencyTree.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8