[SPARK-57795][INFRA][FOLLOWUP] Refine the merge summary comment in merge_spark_pr.py#56923
Closed
zhengruifeng wants to merge 1 commit into
Closed
[SPARK-57795][INFRA][FOLLOWUP] Refine the merge summary comment in merge_spark_pr.py#56923zhengruifeng wants to merge 1 commit into
zhengruifeng wants to merge 1 commit into
Conversation
Rename the header to "Merge Summary:", use full commit SHAs in the links, and move the "Posted by merge_spark_pr.py" attribution to a trailing italic line.
zhengruifeng
changed the title
zhengruifeng
changed the title
Contributor
Author
|
Merge Summary: Posted by |
Contributor
Author
|
oops, this PR is unintentionally merged into master, let me revert it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #56917 (SPARK-57795), which added a merge summary comment posted by
merge_spark_pr.py. This PR refines the format of that comment:**Merge summary** (posted bymerge_spark_pr.py):to**Merge Summary:**.[:8]truncation is dropped inmerge_prand_do_cherry_pick, with.strip()added sincerun_cmddoes not strip the trailing newline.merge_spark_pr.pyattribution to a trailing italic line:*Posted bymerge_spark_pr.py*.Example rendered comment:
Why are the changes needed?
A cleaner, more readable merge summary comment. Full SHAs are unambiguous and link-stable, and moving the tool attribution to the end keeps the summary itself front and center.
Does this PR introduce any user-facing change?
No. This only affects the developer merge tooling.
How was this patch tested?
Manually verified the generated comment body and confirmed the full SHA is carried through. Existing lint (
ruff) passes.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (model: claude-opus-4-8)