Skip to content

Commit 316e3ce

Browse files
committed
Fix unit tests
1 parent 5158276 commit 316e3ce

3 files changed

Lines changed: 17 additions & 3 deletions

File tree

superset/sql_parse.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,10 @@ def extract_tables_from_statement(
281281
if not literal:
282282
return set()
283283

284-
pseudo_query = parse_one(f"SELECT {literal.this}", dialect=dialect)
284+
try:
285+
pseudo_query = parse_one(f"SELECT {literal.this}", dialect=dialect)
286+
except ParseError:
287+
return set()
285288
sources = pseudo_query.find_all(exp.Table)
286289
else:
287290
sources = [

tests/unit_tests/db_engine_specs/test_base.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ class NoLimitDBEngineSpec(BaseEngineSpec):
219219
)
220220
assert (
221221
sql
222-
== """SELECT a
222+
== """SELECT
223+
a
223224
FROM my_table
224225
LIMIT ?
225226
OFFSET ?"""
@@ -238,6 +239,7 @@ class NoLimitDBEngineSpec(BaseEngineSpec):
238239
)
239240
assert (
240241
sql
241-
== """SELECT a
242+
== """SELECT
243+
a
242244
FROM my_table"""
243245
)

tests/unit_tests/jinja_context_test.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,15 @@ def test_dataset_macro(mocker: MockFixture) -> None:
4747
from superset.connectors.sqla.models import SqlaTable, SqlMetric, TableColumn
4848
from superset.models.core import Database
4949

50+
mocker.patch(
51+
"superset.connectors.sqla.models.security_manager.get_guest_rls_filters",
52+
return_value=[],
53+
)
54+
mocker.patch(
55+
"superset.models.helpers.security_manager.get_rls_filters",
56+
return_value=[],
57+
)
58+
5059
columns = [
5160
TableColumn(column_name="ds", is_dttm=1, type="TIMESTAMP"),
5261
TableColumn(column_name="num_boys", type="INTEGER"),

0 commit comments

Comments
 (0)