Skip to content

Commit 3c5e45e

Browse files
author
Brian Donovan
committed
fix(chart): improve sort_by_series description wording
Remove "secondary" from the description since sort_by_series and sort_by_metric are independent controls — either can be used alone. Clarify that the tiebreaker behavior only applies when both are enabled. Fixes prettier formatting (+ at end of line, not beginning).
1 parent 334e59f commit 3c5e45e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

superset-frontend/plugins/plugin-chart-word-cloud/src/plugin/controlPanel.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@ const config: ControlPanelConfig = {
4343
label: t('Sort by series'),
4444
default: false,
4545
description: t(
46-
'Include a secondary sort by series name (ascending). '
47-
+ 'This produces consistent ordering when multiple series have the '
48-
+ 'same metric value, but may reduce query performance on some databases.',
46+
'Sort results by series name in ascending order. ' +
47+
'When combined with "Sort by metric", this acts as a tiebreaker ' +
48+
'for equal metric values. Adding this sort may reduce query ' +
49+
'performance on some databases.',
4950
),
5051
},
5152
},

0 commit comments

Comments
 (0)