File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -105,10 +105,12 @@ export default defineConfig({
105105 } ,
106106 } ,
107107 {
108- // SQL Lab tests share backend tab state per user (/tabstateview/*).
109- // fullyParallel: false ensures all tests run sequentially on one worker
110- // without the skip-on-failure behavior of serial mode — a single test
111- // failure still reports remaining tests independently.
108+ // SQL Lab needs its own project because tab state is stored server-side
109+ // per user (/tabstateview/*). All workers share the same auth user, so
110+ // parallel workers mutating tabs would cause nondeterministic tab counts
111+ // and cross-worker tab deletions. Other test suites (dataset, dashboard,
112+ // chart) don't need this because they create/delete isolated resources
113+ // via API with unique names — no shared mutable state between tests.
112114 name : 'chromium-sqllab' ,
113115 testMatch : '**/tests/sqllab/**/*.spec.ts' ,
114116 fullyParallel : false ,
Original file line number Diff line number Diff line change 1818 */
1919
2020/**
21- * SQL Lab E2E tests — sequential via project-level fullyParallel: false .
21+ * SQL Lab E2E tests — sequential via chromium-sqllab project .
2222 *
23- * SQL Lab persists tabs per user via /tabstateview/*. With fullyParallel and
24- * multiple workers, tests sharing the same authenticated user can overwrite
25- * each other's tab/query state, making tab-count and reload assertions
26- * nondeterministic. The chromium-sqllab project in playwright.config.ts
27- * sets fullyParallel: false so all tests in this file run sequentially on
28- * one worker — without the skip-on-failure behavior of serial mode.
23+ * Tab state is stored server-side per user (/tabstateview/*), and all workers
24+ * share the same authenticated user. Parallel workers adding/removing tabs
25+ * would cause nondeterministic tab counts and cross-worker deletions.
26+ * See playwright.config.ts chromium-sqllab project for details.
2927 */
3028
3129import { test , expect } from '../../helpers/fixtures/testAssets' ;
You can’t perform that action at this time.
0 commit comments