Skip to content

Commit a8c85b2

Browse files
sadpandajoeclaude
andcommitted
fix(playwright): use domcontentloaded for saved-query nav to avoid CI timeout
The saved-query → SQL Lab navigation was timing out in CI because waitUntil: 'load' blocks until all JS/CSS resources finish loading. Switch to 'domcontentloaded' (DOM parsed, before subresources) and bump timeout to API_RESPONSE (15s) since ensureEditorReady() already handles full readiness downstream. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 109efc0 commit a8c85b2

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

superset-frontend/playwright/tests/sqllab/sqllab.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,8 @@ test('saves a query and loads it from saved queries', async ({
238238
// 2. Saved-query API hydration (fires in useEffect after paint)
239239
await queryLink.click();
240240
await page.waitForURL(/sqllab/, {
241-
waitUntil: 'load',
242-
timeout: TIMEOUT.PAGE_LOAD,
241+
waitUntil: 'domcontentloaded',
242+
timeout: TIMEOUT.API_RESPONSE,
243243
});
244244
await waitForGet(page, `api/v1/saved_query/${savedQueryId}`, {
245245
timeout: TIMEOUT.API_RESPONSE,

0 commit comments

Comments
 (0)