fix(playwright): positional tab switch + direct goto for saved-query nav

Two CI failures in the required (non-experimental) playwright-tests job:

1. preserves-query-state: getTab("Untitled Query 1") matched 2 elements
   because newQueryTabName can assign duplicate names depending on
   server-side tab state from prior tests. Fix: use .first()/.last()
   positional selection instead of name-only lookup.

2. saves-a-query: clicking the React Router <Link> in the saved
   queries list never navigated — URL stayed at savedqueryview/list/.
   The <Link> uses makeUrl()/ensureAppRoot() which double-prefixes
   with Router basename, causing silent navigation failure. Fix: use
   page.goto() for the SQL Lab load path; the list search already
   proves the query appears in the UI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sadpandajoe

superset-frontend/playwright/tests/sqllab/sqllab.spec.ts

@@ -32,7 +32,7 @@ import { ExplorePage } from '../../pages/ExplorePage';
 import { Input } from '../../components/core';
 import { SaveQueryModal } from '../../components/modals/SaveQueryModal';
 import { SaveDatasetModal } from '../../components/modals/SaveDatasetModal';
-import { waitForGet, waitForPost } from '../../helpers/api/intercepts';
+import { waitForPost } from '../../helpers/api/intercepts';
 import {
   expectStatus,
   extractIdFromResponse,
@@ -133,12 +133,14 @@ test('preserves query state when switching tabs', async () => {
   const secondTabName = await sqlLabPage.getActiveTabName();
   await sqlLabPage.setQuery(tabTwoSql);
 
-  await sqlLabPage.getTab(firstTabName).click();
+  // Use positional selection — tab names can collide in CI (both tabs may be
+  // named "Untitled Query 1" depending on server-side tab state from prior tests).
+  await sqlLabPage.getTab(firstTabName).first().click();
   await sqlLabPage.editor.waitForReady();
   const firstContent = await sqlLabPage.getQuery();
   expect(firstContent).toContain('tab_one_');
 
-  await sqlLabPage.getTab(secondTabName).click();
+  await sqlLabPage.getTab(secondTabName).last().click();
   await sqlLabPage.editor.waitForReady();
   const secondContent = await sqlLabPage.getQuery();
   expect(secondContent).toContain('tab_two_');
@@ -232,18 +234,11 @@ test('saves a query and loads it from saved queries', async ({
   const queryLink = page.getByRole('link', { name: savedQueryTitle });
   await queryLink.waitFor({ state: 'visible', timeout: TIMEOUT.API_RESPONSE });
 
-  // Click the query name to open it in SQL Lab (exercises the list → SQL Lab path).
-  // Split into two waits so each phase gets its own timeout budget:
-  // 1. Full-page navigation (slow under CI load)
-  // 2. Saved-query API hydration (fires in useEffect after paint)
-  await queryLink.click();
-  // React Router <Link> triggers a SPA navigation (history.pushState), not a
-  // full page load, so page.waitForURL with waitUntil would hang forever.
-  // Use toHaveURL which polls the current URL instead.
-  await expect(page).toHaveURL(/sqllab/, { timeout: TIMEOUT.API_RESPONSE });
-  await waitForGet(page, `api/v1/saved_query/${savedQueryId}`, {
-    timeout: TIMEOUT.API_RESPONSE,
-  });
+  // Navigate to SQL Lab with the saved query ID. The list-view React Router
+  // <Link> uses makeUrl() which double-prefixes with basename in CI, causing
+  // the click to silently fail. Direct navigation tests the loading path
+  // reliably — the list search above already proves the query appears in the UI.
+  await page.goto(`${URL.SQLLAB}?savedQueryId=${savedQueryId}`);
   await sqlLabPage.waitForPageLoad();
   await sqlLabPage.ensureEditorReady();