Skip to content

Commit de61591

Browse files
mapledanmichael-s-molina
authored andcommitted
fix: handle CRLF endings causing sqlglot failure (#26911)
(cherry picked from commit f2bf9f7)
1 parent 61b4017 commit de61591

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

superset/sql_parse.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ def _extract_tables_from_sql(self) -> set[Table]:
286286
Note: this uses sqlglot, since it's better at catching more edge cases.
287287
"""
288288
try:
289-
statements = parse(self.sql, dialect=self._dialect)
289+
statements = parse(self.stripped(), dialect=self._dialect)
290290
except ParseError:
291291
logger.warning("Unable to parse SQL (%s): %s", self._dialect, self.sql)
292292
return set()
@@ -494,7 +494,7 @@ def is_unknown(self) -> bool:
494494
return self._parsed[0].get_type() == "UNKNOWN"
495495

496496
def stripped(self) -> str:
497-
return self.sql.strip(" \t\n;")
497+
return self.sql.strip(" \t\r\n;")
498498

499499
def strip_comments(self) -> str:
500500
return sqlparse.format(self.stripped(), strip_comments=True)

0 commit comments

Comments
 (0)