-
Notifications
You must be signed in to change notification settings - Fork 17.2k
fix(chart): word cloud secondary sort prevents Druid TopN optimization when sort_by_metric enabled #39073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Vitor-Avila
merged 5 commits into
apache:master
from
bdonovan1:fix/word-cloud-druid-topn-sort
Apr 20, 2026
Merged
fix(chart): word cloud secondary sort prevents Druid TopN optimization when sort_by_metric enabled #39073
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c31db93
fix(chart): word cloud secondary sort prevents Druid TopN optimizatio…
6125454
fix(chart): add independent sort_by_series control for word cloud
410a853
chore: retrigger CI
f8ed170
fix(chart): improve sort_by_series description wording
2e1f747
fix(chart): add defensive JSON parsing to migration
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
...rations/versions/2026-04-13_19-28_fd0c8583b46d_add_sort_by_series_to_word_cloud_charts.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| """add sort_by_series to word_cloud charts | ||
|
|
||
| Revision ID: fd0c8583b46d | ||
| Revises: ce6bd21901ab | ||
| Create Date: 2026-04-13 19:28:19.021839 | ||
|
|
||
| """ | ||
|
|
||
| from alembic import op | ||
| from sqlalchemy import Column, Integer, String, Text | ||
| from sqlalchemy.ext.declarative import declarative_base | ||
|
|
||
| from superset import db | ||
| from superset.migrations.shared.utils import paginated_update | ||
| from superset.utils import json | ||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = "fd0c8583b46d" | ||
| down_revision = "ce6bd21901ab" | ||
|
|
||
| Base = declarative_base() | ||
|
|
||
|
|
||
| class Slice(Base): | ||
| __tablename__ = "slices" | ||
| id = Column(Integer, primary_key=True) | ||
| viz_type = Column(String(250)) | ||
| params = Column(Text) | ||
|
|
||
|
|
||
| def upgrade_params(params: dict) -> dict: | ||
| if "sort_by_series" not in params: | ||
| params["sort_by_series"] = True | ||
| return params | ||
|
|
||
|
|
||
| def downgrade_params(params: dict) -> dict: | ||
| params.pop("sort_by_series", None) | ||
| return params | ||
|
|
||
|
|
||
| def upgrade(): | ||
| bind = op.get_bind() | ||
| session = db.Session(bind=bind) | ||
|
|
||
| for slc in paginated_update( | ||
| session.query(Slice).filter(Slice.viz_type == "word_cloud") | ||
| ): | ||
| try: | ||
| params = json.loads(slc.params or "{}") | ||
| if not isinstance(params, dict): | ||
| continue | ||
| slc.params = json.dumps(upgrade_params(params)) | ||
| except (json.JSONDecodeError, TypeError): | ||
| continue | ||
| session.close() | ||
|
|
||
|
|
||
| def downgrade(): | ||
| bind = op.get_bind() | ||
| session = db.Session(bind=bind) | ||
|
|
||
| for slc in paginated_update( | ||
| session.query(Slice).filter(Slice.viz_type == "word_cloud") | ||
| ): | ||
| try: | ||
| params = json.loads(slc.params or "{}") | ||
| if not isinstance(params, dict): | ||
| continue | ||
| slc.params = json.dumps(downgrade_params(params)) | ||
| except (json.JSONDecodeError, TypeError): | ||
| continue | ||
| session.close() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.