chore(deps): bump ag-grid-community from 35.0.1 to 35.2.0 in /superset-frontend#39085
Conversation
Bumps [ag-grid-community](https://github.com/ag-grid/ag-grid) from 35.0.1 to 35.2.0. - [Release notes](https://github.com/ag-grid/ag-grid/releases) - [Commits](ag-grid/ag-grid@release-35.0.1...release-35.2.0) --- updated-dependencies: - dependency-name: ag-grid-community dependency-version: 35.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Bito Automatic Review Skipped - Files Excluded |
ag-grid-react 35.0.1 has an exact dependency on ag-grid-community 35.0.1, so bumping only ag-grid-community to 35.2.0 caused npm to install a nested ag-grid-community@35.0.1 inside ag-grid-react's node_modules. This produced two parallel copies of ag-grid-community: - AgGridReact (from ag-grid-react) used its bundled 35.0.1 module registry, which had no modules registered (setupAGGridModules registers on the top-level 35.2.0 copy). Without ClientSideRowModelModule, the grid renders an empty container with no role="grid" element, breaking 11 FilterableTable jest tests and ResultSet/GridTable tests. - TypeScript surfaced the duplication as "Argument of type 'GridApi' is not assignable to parameter of type 'GridApi'" errors in plugin-chart-ag-grid-table (lint-frontend / validate-frontend). Bumping ag-grid-react (and the same pin in superset-ui-core) to 35.2.0 dedupes the install back to a single copy, restoring the accessible DOM and resolving the type mismatch. Files: superset-frontend/package.json, superset-frontend/packages/superset-ui-core/package.json, superset-frontend/package-lock.json
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39085 +/- ##
=======================================
Coverage 64.54% 64.54%
=======================================
Files 2536 2536
Lines 131164 131164
Branches 30451 30451
=======================================
Hits 84659 84659
Misses 45042 45042
Partials 1463 1463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
|
Looks like ag-grid-community is up-to-date now, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/superset-frontend/ag-grid-community-35.2.0
branch
1 participant
Bumps ag-grid-community from 35.0.1 to 35.2.0.
Release notes
Sourced from ag-grid-community's releases.
Commits
dbe8ab3Release 35.2.0 Prep085f005Take account of ai blocks7225619Release 35.2.0 Prep09be48d[RTI-3260] Fix(columns): staged state equivalent to current still shows apply...05a5047RTI-3282-more-docs-fixes-for-group-edit (#13396)2016765[RTI-3309] Fix(docs): restructure ctp deferred updates example and align csrm...8e87b78RTI-3258 Fix Doc tests for animations (#13368)6ae1cceRelease 35.2.0 Prepa05a652RTI-3257-more-fixes-to-group-row-editable (#13393)5a80b92Release 35.2.0 PrepDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)