fix(i18n): add Slovenian translation for 'Range type' in DateFilter#40287
fix(i18n): add Slovenian translation for 'Range type' in DateFilter#40287miharejec wants to merge 1 commit into
Conversation
The 'Range type' and 'Range Type' translation entries were marked as fuzzy, so they were not being used. Remove the fuzzy flag and fix the translation casing from 'TIP OBDOBJA' to 'Tip obdobja'.
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #18855a
Actionable Suggestions - 1
-
superset/translations/sl/LC_MESSAGES/messages.po - 1
- Semantic duplication in translations · Line 9930-9931
Additional Suggestions - 1
-
superset/translations/sl/LC_MESSAGES/messages.po - 1
-
Translation style inconsistency · Line 9930-9931The translation changed from all-caps "TIP OBDOBJA" to title case "Tip obdobja". While title case is generally preferred, this creates a style inconsistency with the original translation pattern. Verify this matches the intended style for the translation file.
-
Review Details
-
Files reviewed - 1 · Commit Range:
e0f5ed2..e0f5ed2- superset/translations/sl/LC_MESSAGES/messages.po
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| msgid "Range Type" | ||
| msgstr "TIP OBDOBJA" | ||
| msgstr "Tip obdobja" |
There was a problem hiding this comment.
The msgid "Range Type" (line 9930) and msgid "Range type" (line 9942) are distinct case-sensitive strings that now share the identical translation "Tip obdobja". These likely appear as different UI labels and should have distinct translations to prevent user confusion.
Code Review Run #18855a
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
sadpandajoe
added
the
merge-if-green
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40287 +/- ##
=======================================
Coverage 64.16% 64.16%
=======================================
Files 2591 2591
Lines 138293 138293
Branches 32084 32084
=======================================
Hits 88736 88736
Misses 48027 48027
Partials 1530 1530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
SUMMARY
The "Range type" label in the DateFilter popover was showing untranslated in Slovenian. The translation entries for
"Range Type"and"Range type"existed in the.pofile but were marked as#, fuzzy, which means they are ignored by the translation system. This PR removes the fuzzy flag and corrects the translation casing to"Tip obdobja".TESTING INSTRUCTIONS
Configure Superset with Slovenian locale
Open a chart or dashboard time range filter
The label above the range type dropdown should now show "Tip obdobja" instead of "Range type"
ADDITIONAL INFORMATION