Skip to content

feat(i18n): expose the six newly backfilled locales#41827

Open
rusackas wants to merge 2 commits into
masterfrom
feat/i18n-expose-backfilled-languages
Open

feat(i18n): expose the six newly backfilled locales#41827
rusackas wants to merge 2 commits into
masterfrom
feat/i18n-expose-backfilled-languages

Conversation

@rusackas

@rusackas rusackas commented Jul 6, 2026

Copy link
Copy Markdown
Member

SUMMARY

The i18n backfill campaign left every catalog in superset/translations/ with zero untranslated entries, but six of them — Arabic, Catalan, Persian, Finnish, Thai, Turkish — were never added to the LANGUAGES reference dict in config.py, so operators who enable i18n still can't select them. This adds the six entries with their flag codes.

Also completes the frontend Locale type union in @superset-core to the full set of catalog locales: it had drifted to 12 of 29 (missing not just these six but also mi/uk/sk/sl/lv/nl/pl/cs/ro/sr/sr_Latn). Type-level only; no runtime change.

Note LANGUAGES remains {} by default (i18n stays opt-in) — this only extends the reference dict operators copy from.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — config reference + type union.

TESTING INSTRUCTIONS

Enable the six locales in superset_config.py, switch languages in the UI, observe translated content (catalogs are fully backfilled; AI-generated entries are fuzzy-served pending human review, per the backfill convention).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

Adds Arabic, Catalan, Persian, Finnish, Thai, and Turkish to the
LANGUAGES reference dict in config.py — all six have fully backfilled
catalogs on master but were not selectable even for operators who
enable i18n. Also completes the frontend Locale type union to the full
set of catalog locales (it had drifted to 12 of 29).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@dosubot dosubot Bot added the i18n:general Related to translations label Jul 6, 2026
@bito-code-review

bito-code-review Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #b888ad

Actionable Suggestions - 0
Additional Suggestions - 1
  • superset/config.py - 1
    • Dead code from immediate overwrite · Line 526-531
      Lines 526-531 add 6 new language entries (`ar`, `ca`, `fa`, `fi`, `th`, `tr`) to the `LANGUAGES` dict, but line 535 immediately overwrites it with `LANGUAGES = {}`. These additions are semantically dead code with zero functional impact. While the immediate overwrite is intentional (i18n disabled by default), adding entries that are instantly discarded creates maintenance confusion and contradicts the principle that default config lists should match documented intent.
Review Details
  • Files reviewed - 2 · Commit Range: 0fd8795..0fd8795
    • superset-frontend/packages/superset-core/src/translation/types/index.ts
    • superset/config.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.21%. Comparing base (847bdad) to head (758f8c4).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #41827      +/-   ##
==========================================
- Coverage   64.77%   64.21%   -0.57%     
==========================================
  Files        2689     2689              
  Lines      148945   148945              
  Branches    34369    34369              
==========================================
- Hits        96479    95642     -837     
- Misses      50697    51534     +837     
  Partials     1769     1769              
Flag Coverage Δ
hive 39.19% <ø> (ø)
javascript 69.66% <ø> (ø)
mysql 57.86% <ø> (ø)
postgres 57.92% <ø> (ø)
presto 40.73% <ø> (ø)
python 58.13% <ø> (-1.19%) ⬇️
sqlite 57.50% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n:general Related to translations packages size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants