drop /dashboard prefix from user-facing URLs

Author: Ma77Ball

amber/src/main/scala/org/apache/texera/web/service/WorkflowEmailNotifier.scala

@@ -107,7 +107,7 @@ class WorkflowEmailNotifier(
   private def createDashboardUrl(): String = {
     val host = sessionUri.getHost
     val port = sessionUri.getPort
-    val path = s"/dashboard/user/workspace/$workflowId"
+    val path = s"/user/workspace/$workflowId"
     if (port == -1 || port == 80 || port == 443) {
       s"http://$host$path"
     } else {

frontend/src/app/app-routing.constant.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-export const DASHBOARD = "/dashboard";
+export const DASHBOARD = "";
 export const DASHBOARD_HOME = `${DASHBOARD}/home`;
 export const DASHBOARD_ABOUT = `${DASHBOARD}/about`;
 

frontend/src/app/app-routing.module.ts

@@ -17,8 +17,8 @@
  * under the License.
  */
 
-import { inject, NgModule } from "@angular/core";
-import { CanActivateFn, Router, RouterModule, Routes } from "@angular/router";
+import { NgModule } from "@angular/core";
+import { RouterModule, Routes } from "@angular/router";
 import { DashboardComponent } from "./dashboard/component/dashboard.component";
 import { UserWorkflowComponent } from "./dashboard/component/user/user-workflow/user-workflow.component";
 import { UserQuotaComponent } from "./dashboard/component/user/user-quota/user-quota.component";
@@ -38,28 +38,21 @@ import { DatasetDetailComponent } from "./dashboard/component/user/user-dataset/
 import { UserDatasetComponent } from "./dashboard/component/user/user-dataset/user-dataset.component";
 import { HubWorkflowDetailComponent } from "./hub/component/workflow/detail/hub-workflow-detail.component";
 import { LandingPageComponent } from "./hub/component/landing-page/landing-page.component";
-import { DASHBOARD_ABOUT, DASHBOARD_USER_WORKFLOW } from "./app-routing.constant";
+import { DASHBOARD_USER_WORKFLOW } from "./app-routing.constant";
 import { HubSearchResultComponent } from "./hub/component/hub-search-result/hub-search-result.component";
 import { AdminSettingsComponent } from "./dashboard/component/admin/settings/admin-settings.component";
-import { GuiConfigService } from "./common/service/gui-config.service";
-
-const rootRedirectGuard: CanActivateFn = () => {
-  const config = inject(GuiConfigService);
-  const router = inject(Router);
-  try {
-    return router.parseUrl(DASHBOARD_ABOUT);
-  } catch {
-    // config not loaded yet, swallow the error and let the app handle it
-  }
-  return true;
-};
 
 const routes: Routes = [];
 
 routes.push({
-  path: "dashboard",
+  path: "",
   component: DashboardComponent,
   children: [
+    {
+      path: "",
+      redirectTo: "about",
+      pathMatch: "full",
+    },
     {
       path: "home",
       component: LandingPageComponent,
@@ -174,14 +167,6 @@ routes.push({
   ],
 });
 
-// default route renders the workspace editor directly; if userSystem is enabled at runtime,
-// AppComponent will navigate to DASHBOARD_ABOUT instead.
-routes.push({
-  path: "",
-  component: WorkspaceComponent,
-  canActivate: [rootRedirectGuard],
-});
-
 // redirect all other paths to index.
 routes.push({
   path: "**",

frontend/src/app/dashboard/component/admin/execution/admin-execution.component.html

@@ -100,7 +100,7 @@
     <tr *ngFor="let execution of basicTable.data">
       <td>
         <div *ngIf="execution.access; else normalWorkflowName">
-          <a href="/dashboard/user/workflow/{{execution.workflowId}}">
+          <a href="/user/workflow/{{execution.workflowId}}">
             {{ maxStringLength(execution.workflowName, 16) }} ({{ execution.workflowId }})
           </a>
         </div>

frontend/src/app/dashboard/component/dashboard.component.spec.ts

@@ -80,8 +80,8 @@ describe("DashboardComponent", () => {
     };
 
     routerMock = {
-      events: of(new NavigationEnd(1, "/dashboard", "/dashboard")),
-      url: "/dashboard",
+      events: of(new NavigationEnd(1, "/", "/")),
+      url: "/",
       navigateByUrl: vi.fn(),
     };
 

frontend/src/app/dashboard/component/dashboard.component.ts

@@ -232,7 +232,7 @@ export class DashboardComponent implements OnInit {
 
   isNavbarEnabled(currentRoute: string) {
     // Hide navbar for workflow workspace pages (with numeric ID)
-    if (currentRoute.match(/\/dashboard\/user\/workflow\/\d+/)) {
+    if (currentRoute.match(/\/user\/workflow\/\d+/)) {
       return false;
     }
     return true;

frontend/src/app/dashboard/component/user/share-access/share-access.component.ts

@@ -190,7 +190,7 @@ export class ShareAccessComponent implements OnInit, OnDestroy {
       this.emailTags.forEach(email => {
         let message = `${this.userService.getCurrentUser()?.email} shared a ${this.type} with you`;
         if (this.type !== "computing-unit")
-          message += `, access the ${this.type} at ${location.origin}/dashboard/user/workflow/${this.id}`;
+          message += `, access the ${this.type} at ${location.origin}/user/workflow/${this.id}`;
         this.accessService
           .grantAccess(this.type, this.id, email, this.validateForm.value.accessLevel)
           .pipe(untilDestroyed(this))