Skip to content

Commit b83d948

Browse files
committed
fix(frontend): remove unused NgxJsonViewerModule, guard JSON.stringify undefined, and use ogv for video extension
1 parent 07ea941 commit b83d948

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

frontend/src/app/common/util/media-type.util.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ describe("isVideoUrl", () => {
9999
it("should return true for common video file extensions", () => {
100100
expect(isVideoUrl("https://example.com/clip.mp4")).toBe(true);
101101
expect(isVideoUrl("https://example.com/clip.webm")).toBe(true);
102-
expect(isVideoUrl("https://example.com/clip.ogg")).toBe(true);
102+
expect(isVideoUrl("https://example.com/clip.ogv")).toBe(true);
103103
});
104104

105105
it("should return true for fal.media CDN URLs", () => {

frontend/src/app/common/util/media-type.util.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
export function isVideoUrl(value: string): boolean {
2121
if (typeof value !== "string") return false;
2222
return (
23-
value.match(/\.(mp4|webm|ogg)(\?.*)?$/i) !== null ||
23+
value.match(/\.(mp4|webm|ogv)(\?.*)?$/i) !== null ||
2424
value.startsWith("data:video/") ||
2525
value.startsWith("https://v3b.fal.media/files/")
2626
);

frontend/src/app/workspace/component/result-panel/result-panel-modal.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import { NzIconModule } from "ng-zorro-antd/icon";
2525
import { WorkflowResultService } from "../../service/workflow-result/workflow-result.service";
2626
import { UntilDestroy, untilDestroyed } from "@ngneat/until-destroy";
2727
import { PanelResizeService } from "../../service/workflow-result/panel-resize/panel-resize.service";
28-
import { NgxJsonViewerModule } from "ngx-json-viewer";
2928
import { NotificationService } from "../../../common/service/notification/notification.service";
3029
import { isAudioUrl, isVideoUrl, isImageUrl } from "src/app/common/util/media-type.util";
3130
import { AppSettings } from "../../../common/app-setting";
@@ -48,7 +47,7 @@ import { AppSettings } from "../../../common/app-setting";
4847
selector: "texera-row-modal-content",
4948
templateUrl: "./result-panel-modal.component.html",
5049
styleUrls: ["./result-panel-model.component.scss"],
51-
imports: [CommonModule, NzButtonModule, NzIconModule, NgxJsonViewerModule],
50+
imports: [CommonModule, NzButtonModule, NzIconModule],
5251
})
5352
export class RowModalComponent implements OnChanges {
5453
rowEntries: { key: string; value: string; mediaSrc: string; isVideo: boolean; isImage: boolean; isAudio: boolean }[] =

0 commit comments

Comments
 (0)