Skip to content

Commit bd9fa60

Browse files
aicamclaude
andcommitted
refactor(k8s): organize Helm templates into common/aws/onprem
Group the chart's templates by where they apply so the layout makes the deployment surface obvious at a glance: templates/common/ resources every deployment needs (services, gateway, postgres/lakefs/lakekeeper, computing-unit pool, RBAC) templates/onprem/ self-hosted-only resources (in-cluster MinIO) templates/aws/ AWS/EKS-only resources (added in later PRs; placeholder) Helm renders templates/** recursively, so this is purely organizational: `helm template` output is byte-identical to before the move (verified, modulo the chart's pre-existing per-render random LakeFS keys). A templates/README.md documents the convention and a .helmignore keeps the doc and .gitkeep placeholder from being loaded as manifests. Also bring values-development.yaml back in line with values.yaml (the ground truth), which had drifted: - image source: docker.io/apache + 1.3.0-incubating-SNAPSHOT (was the stale ghcr.io/apache + latest), so both value files pull from the same place; - add the AUTH_JWT_SECRET entry to texeraEnvVars. values.yaml has it but the dev profile omitted it, so the computing-unit manager started without the secret and k8s computing-unit creation crashed with NoSuchElementException (None.get) in ComputingUnitManagingResource. Adding it (same dev-only default as values.yaml) makes CU creation work under the dev profile. No behavior change to the default (on-prem) install. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 07724d5 commit bd9fa60

42 files changed

Lines changed: 92 additions & 2 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

bin/k8s/.helmignore

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Patterns to ignore when building Helm packages.
2+
# Operating system / editor files
3+
.DS_Store
4+
*.swp
5+
*.bak
6+
*.tmp
7+
*.orig
8+
*~
9+
# Version control directories
10+
.git/
11+
.gitignore
12+
# Documentation kept alongside the chart for humans, not rendered as manifests.
13+
# Markdown under templates/ (e.g. the common/aws/onprem layout guide) must be
14+
# ignored so Helm does not try to load it as a Kubernetes manifest.
15+
*.md
16+
# git placeholders must not be loaded by Helm as manifests
17+
.gitkeep

bin/k8s/templates/README.md

Lines changed: 68 additions & 0 deletions

bin/k8s/templates/aws/.gitkeep

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Placeholder so the (initially empty) aws/ template folder is tracked in git.
2+
# AWS-only, value-gated templates are added by later PRs in the AWS/EKS series.

bin/k8s/templates/access-control-service-deployment.yaml renamed to bin/k8s/templates/common/access-control-service/access-control-service-deployment.yaml

File renamed without changes.

bin/k8s/templates/access-control-service-service.yaml renamed to bin/k8s/templates/common/access-control-service/access-control-service-service.yaml

File renamed without changes.

bin/k8s/templates/agent-service-backend-traffic-policy.yaml renamed to bin/k8s/templates/common/agent-service/agent-service-backend-traffic-policy.yaml

File renamed without changes.

bin/k8s/templates/agent-service-deployment.yaml renamed to bin/k8s/templates/common/agent-service/agent-service-deployment.yaml

File renamed without changes.

bin/k8s/templates/agent-service-secret.yaml renamed to bin/k8s/templates/common/agent-service/agent-service-secret.yaml

File renamed without changes.

bin/k8s/templates/agent-service-service.yaml renamed to bin/k8s/templates/common/agent-service/agent-service-service.yaml

File renamed without changes.

bin/k8s/templates/config-service-deployment.yaml renamed to bin/k8s/templates/common/config-service/config-service-deployment.yaml

File renamed without changes.

0 commit comments

Comments
 (0)