Skip to content

joint-ui.service.spec carries commented-out tests pointing at removed APIs and an it.todo placeholder #5195

@Yicong-Huang

Description

@Yicong-Huang

Task Summary

joint-ui.service.spec.ts keeps ten it() blocks commented out at the top of the file (roughly lines 43–236), plus an it.todo("add unit tests for JointUIService") placeholder at line 339. Five of the seven SUT methods those commented tests call have since been removed from JointUIService (getJointOperatorStatusTooltipElement, changeOperatorStates plural, changeOperatorTooltipInfo, showToolTip, hideTooltip); two are still alive (getJointOperatorElement, changeOperatorState singular). The SUT itself currently runs at ~47 % line coverage (222 lines, 106 misses), so the spec is a high-value cleanup target — drop the dead commented tests, adapt or replace the two whose methods survived, and add coverage for the still-public surface (changeOperatorStatistics, foldOperatorDetails / unfoldOperatorDetails, changeOperatorColor, the getMarkup static helper, etc.).

Task Type

  • Testing / QA
  • Refactor / Cleanup

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions