refactor: move shared computing unit types and services to frontend/src/app/common#4358
refactor: move shared computing unit types and services to frontend/src/app/common#4358gracecluvohio wants to merge 9 commits intoapache:mainfrom
frontend/src/app/common#4358Conversation
|
@gracecluvohio Please fix the failed test cases. |
There was a problem hiding this comment.
| .../workspace/service/workflow-computing-unit | .../common/service/computing-unit/computing-unit-managing |
|---|
Is there a reason you changed the folder name from workflow-computing-unit to computing-unit-managing?
There was a problem hiding this comment.
Just because it's no longer just for workflow, it's also for dashboard. Should I change the name of the file and the component as well?
There was a problem hiding this comment.
Let's wait for @bobbai00's input as he is familiar with these codes.
There was a problem hiding this comment.
I suggest we revert this change. This PR should ONLY move folders from one place to another
There was a problem hiding this comment.
@bobbai00 Do you think it's a good idea to make another PR to rename the directory so that its name is more consistent with how it's used? And maybe also the components? I think the term "workflow" is outdated and a bit misleading now.
|
@bobbai00 When you have the chance could you take a look at this PR? Also could you try merging main into this PR again? Seems like pytest failed but I think it may just be a one-time thing. |
bobbai00
changed the title
frontend/src/app/common
bobbai00
left a comment
bobbai00
left a comment
There was a problem hiding this comment.
Please revert the renaming change. Other parts LGTM
…ing" back to "workflow-computing-unit"
…es' into reorganize-computing-unit-services
4 participants
What changes were proposed in this PR?
(For readability,
...refers tofrontend/src/appin the codebase.)This PR moves shared computing unit types and services to
.../commonunderfrontend/src/app. Specifically:.../dashboard/service/user/computing-unit-actions.../common/service/computing-unit/computing-unit-actions.../workspace/service/workflow-computing-unit.../common/service/computing-unit/computing-unit-managing.../workspace/service/computing-unit-status.../common/service/computing-unit/computing-unit-status.../workspace/types/computing-unit-connection.interface.ts.../common/type/computing-unit-connection.interface.ts.../workspace/types/workflow-computing-unit.ts.../common/type/workflow-computing-unit.tsAny related issues, documentation, discussions?
Closes #4362
How was this PR tested?
Locally tested
Was this PR authored or co-authored using generative AI tooling?
No