Skip to content

refactor(frontend): move shared computing unit types and services to frontend/src/app/common#4358

Merged
bobbai00 merged 12 commits intoapache:mainfrom
gracecluvohio:reorganize-computing-unit-services
Apr 16, 2026
Merged

refactor(frontend): move shared computing unit types and services to frontend/src/app/common#4358
bobbai00 merged 12 commits intoapache:mainfrom
gracecluvohio:reorganize-computing-unit-services

Conversation

@gracecluvohio
Copy link
Copy Markdown
Contributor

@gracecluvohio gracecluvohio commented Apr 10, 2026

What changes were proposed in this PR?

(For readability, ... refers to frontend/src/app in the codebase.)

This PR moves shared computing unit types and services to .../common under frontend/src/app. Specifically:

Original location New location
.../dashboard/service/user/computing-unit-actions .../common/service/computing-unit/computing-unit-actions
.../workspace/service/workflow-computing-unit .../common/service/computing-unit/computing-unit-managing
.../workspace/service/computing-unit-status .../common/service/computing-unit/computing-unit-status
.../workspace/types/computing-unit-connection.interface.ts .../common/type/computing-unit-connection.interface.ts
.../workspace/types/workflow-computing-unit.ts .../common/type/workflow-computing-unit.ts

Any related issues, documentation, discussions?

Closes #4362

How was this PR tested?

Locally tested

Was this PR authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the frontend Changes related to the frontend GUI label Apr 10, 2026
@chenlica chenlica requested review from bobbai00 and kunwp1 April 11, 2026 00:00
@chenlica
Copy link
Copy Markdown
Contributor

@gracecluvohio Please fix the failed test cases.

@kunwp1 and @bobbai00 Please review it after that.

Copy link
Copy Markdown
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor comment

@gracecluvohio
Copy link
Copy Markdown
Contributor Author

@bobbai00 When you have the chance could you take a look at this PR? Also could you try merging main into this PR again? Seems like pytest failed but I think it may just be a one-time thing.

@bobbai00 bobbai00 changed the title refactor: move shared computing unit types and services refactor: move shared computing unit types and services to frontend/src/app/common Apr 13, 2026
Copy link
Copy Markdown
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the renaming change. Other parts LGTM

@gracecluvohio gracecluvohio requested a review from bobbai00 April 14, 2026 00:27
@bobbai00 bobbai00 changed the title refactor: move shared computing unit types and services to frontend/src/app/common refactor(frontend): move shared computing unit types and services to frontend/src/app/common Apr 16, 2026
@bobbai00 bobbai00 enabled auto-merge (squash) April 16, 2026 04:48
@bobbai00 bobbai00 merged commit 407a91f into apache:main Apr 16, 2026
11 checks passed
bobbai00 added a commit to bobbai00/texera that referenced this pull request Apr 18, 2026
…`frontend/src/app/common` (apache#4358)

<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
  2. Ensure you have added or run the appropriate tests for your PR
  3. If the PR is work in progress, mark it a draft on GitHub.
  4. Please write your PR title to summarize what this PR proposes, we 
    are following Conventional Commits style for PR titles as well.
  5. Be sure to keep the PR description updated to reflect all changes.
-->

### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, you can clarify why it is a bug.
  3. If it is a refactoring, clarify what has been changed.
  3. It would be helpful to include a before-and-after comparison using 
     screenshots or GIFs.
  4. Please consider writing useful notes for better and faster reviews.
-->
(For readability, `...` refers to `frontend/src/app` in the codebase.)

This PR moves shared computing unit types and services to `.../common`
under `frontend/src/app`. Specifically:
| Original location | New location | 
| ---------------- | ------------- |
| `.../dashboard/service/user/computing-unit-actions` |
`.../common/service/computing-unit/computing-unit-actions` |
| `.../workspace/service/workflow-computing-unit` |
`.../common/service/computing-unit/computing-unit-managing` |
| `.../workspace/service/computing-unit-status` |
`.../common/service/computing-unit/computing-unit-status` |
| `.../workspace/types/computing-unit-connection.interface.ts` |
`.../common/type/computing-unit-connection.interface.ts` |
| `.../workspace/types/workflow-computing-unit.ts` |
`.../common/type/workflow-computing-unit.ts` |

### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves
apache#1234`
or `Closes apache#1234`. If it is only related, simply mention the issue
number.
  2. If there is design documentation, please add the link.
  3. If there is a discussion in the mailing list, please add the link.
-->
Closes apache#4362 

### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
Locally tested

### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'. 
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
No

---------

Co-authored-by: Chen Li <chenli@gmail.com>
Co-authored-by: Kunwoo (Chris) <143021053+kunwp1@users.noreply.github.com>
Co-authored-by: Jiadong Bai <43344272+bobbai00@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Shared Computing Unit Types and Services to Common Folder

4 participants