chore: clean up sbt clean compile warnings#5201
Open
kunwp1 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5201 +/- ##
============================================
+ Coverage 47.15% 47.19% +0.04%
- Complexity 2348 2349 +1
============================================
Files 1042 1042
Lines 39989 39981 -8
Branches 4260 4262 +2
============================================
+ Hits 18855 18868 +13
+ Misses 20012 19987 -25
- Partials 1122 1126 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kunwp1
force-pushed
the
chore/fix-sbt-warnings
branch
from
325ace2 to
43ae460
Compare
Fixes the eight Scala/Java compiler warnings on JDK 17: lift the nested BoundaryValidator case classes to its companion object, switch the DatasetFileNodeSerializer to scala.jdk.javaapi.CollectionConverters, delete the unused inMemoryMySQLSourceOpDesc test helper, add the scala.language.existentials import in ExecutionResultService, and drop the aspirational @deprecated marker on the JwtAuth wrapper (no replacement exists in common/auth yet; TODO retained). Closes apache#5200
kunwp1
force-pushed
the
chore/fix-sbt-warnings
branch
from
43ae460 to
dab49c1
Compare
Contributor
|
Could you please also add some tests? just to verify those changes have no behavior changes. |
| // TODO: move this logic to Auth | ||
| @Deprecated | ||
| // TODO: move this logic to common/auth once it depends on Dropwizard, so amber | ||
| // services can drop the toastshaman dropwizard-auth-jwt filter. |
Contributor
There was a problem hiding this comment.
Removing the deprecated is a behavior change. Let's keep the deprecation. It is fine to keep that in warning. The way to remove this warning is to actually remove this code
| aggOp | ||
| } | ||
|
|
||
| def inMemoryMySQLSourceOpDesc( |
Contributor
There was a problem hiding this comment.
MySQL exec implementation was disabled due to license issue. We can remove this (used for test) for now. @bobbai00 whats our plan to add mysql back?
| gen.writeStartArray(); | ||
| List<DatasetFileNode> children = value.getChildren(); | ||
| for (DatasetFileNode child : JavaConverters.seqAsJavaList(children)) { | ||
| for (DatasetFileNode child : CollectionConverters.asJava(children)) { |
Contributor
There was a problem hiding this comment.
Can we turn this one into an error? So that it can prevent the wrong pattern being introduced again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Fixes the eight
[warn]/deprecation messages emitted bysbt clean compileon JDK 17:common/pybuilder/.../BoundaryValidator.scalaCompileTimeContext/RuntimeContextcase classes to the companion object; the path-dependent macroPositionbecomes aPostype parameter. Call sites inPythonTemplateBuilder.scalaswitch fromvalidator.X(...)toBoundaryValidator.X(...).file-service/.../DatasetFileNodeSerializer.javascala.collection.JavaConverters.seqAsJavaListforscala.jdk.javaapi.CollectionConverters.asJava.common/workflow-operator/.../TestOperators.scalaMySQLSourceOpDescdeprecated (×2)inMemoryMySQLSourceOpDeschelper and its import (no callers; MySQL source dead since 1.1.0-incubating).amber/.../ExecutionResultService.scalaimport scala.language.existentials.amber/.../web/auth/JwtAuth.scala(used inComputingUnitMaster.scala&TexeraWebApplication.scala)JwtAuthobject deprecated (×2)@Deprecatedon the wrapper.common/authdoesn't depend on Dropwizard, so amber has no replacement to migrate to until that changes. TODO retained on the object with the migration rationale, so the future cleanup is still tracked.Any related issues, documentation, discussions?
Closes #5200
How was this PR tested?
sbt clean compileon Eclipse Adoptium JDK 17.0.19:Before:
After: zero
[warn]lines fromsbt clean compile; build still succeeds.No behavior changes — these are warning cleanups only, so existing test suites cover correctness. No new tests added.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)