feat: add card view to the user dataset listing#5947
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5947 +/- ##
============================================
+ Coverage 54.84% 54.92% +0.08%
+ Complexity 2957 2956 -1
============================================
Files 1115 1117 +2
Lines 43019 43165 +146
Branches 4633 4654 +21
============================================
+ Hits 23592 23707 +115
- Misses 18040 18060 +20
- Partials 1387 1398 +11
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aicam
approved these changes
Jun 26, 2026
aicam
left a comment
aicam
left a comment
Contributor
There was a problem hiding this comment.
LGTM! just address comments and merge
xuang7
force-pushed
the
feat/private-datasets-card-view
branch
from
594f545 to
871cb72
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 29, 2026
…nt (apache#5949) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> > [Stacked on apache#5947] This PR consolidates the public and private dataset listings to use the shared CardItemComponent. - Replace texera-dataset-card-item with the shared read-only texera-card-item in the public hub. - Remove the unused DatasetCardItemComponent and its tests. - Align the hub list/card toggle with the workflow and private dataset listings. - Update the like button styling on the shared card. This keeps dataset cards consistent across all listings and reduces duplicated code. Demo: <img width="1258" height="400" alt="public-datasets" src="https://github.com/user-attachments/assets/49a083f1-d2a4-47f5-99a4-d70f90ccd947" /> ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> Closes apache#5948 ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> All existing tests passed, and the changes were manually tested. ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Generated-by: Claude Opus 4.8
Mrudhulraj
pushed a commit
to Mrudhulraj/texera
that referenced
this pull request
Jun 30, 2026
…nt (apache#5949) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> > [Stacked on apache#5947] This PR consolidates the public and private dataset listings to use the shared CardItemComponent. - Replace texera-dataset-card-item with the shared read-only texera-card-item in the public hub. - Remove the unused DatasetCardItemComponent and its tests. - Align the hub list/card toggle with the workflow and private dataset listings. - Update the like button styling on the shared card. This keeps dataset cards consistent across all listings and reduces duplicated code. Demo: <img width="1258" height="400" alt="public-datasets" src="https://github.com/user-attachments/assets/49a083f1-d2a4-47f5-99a4-d70f90ccd947" /> ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> Closes apache#5948 ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> All existing tests passed, and the changes were manually tested. ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Generated-by: Claude Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds a card view to the user's private dataset listing (/user/dataset). The card view reuses the existing generic CardItemComponent (the list-item/card-item card already used by the private workflow listing) and renders the dataset cover image.
Any related issues, documentation, discussions?
Closes #5312
How was this PR tested?
Added 5 unit tests covering dataset cover preview loading, fallback to the default image, image load failure handling, workflow card regression, and dataset view type updates. Also manually tested the related UI changes.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8