Skip to content

THRIFT-5064: Introduce Perl::Critic into the SCA#3446

Open
kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk:sca-perl
Open

THRIFT-5064: Introduce Perl::Critic into the SCA#3446
kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk:sca-perl

Conversation

@kpumuk
Copy link
Copy Markdown
Member

@kpumuk kpumuk commented May 3, 2026

Introduce Perl::Critic into the SCA build. Extends on the prior art #1982, but additionally introduces Perl::Critic tags into the generated code, so it also passes validations.

  • Did you create an Apache Jira ticket? THRIFT-5064
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable Bot added perl compiler testsuite github_actions Pull requests that update GitHub Actions code labels May 3, 2026
@mergeable mergeable Bot added the build and general CI cmake, automake and build system changes label May 3, 2026
@kpumuk kpumuk marked this pull request as draft May 3, 2026 23:05
@kpumuk kpumuk marked this pull request as ready for review May 3, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build and general CI cmake, automake and build system changes compiler github_actions Pull requests that update GitHub Actions code perl testsuite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant