Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR (TIKA-4733) tightens release/distribution handling for Tika 4.x artifacts and updates CLI messaging/docs to better reflect the “zip distribution with lib/” packaging model.
Changes:
- Drop the redundant
-bin.tgzserver distribution, standardizing on.zip. - Prevent selected distribution zips from being attached/deployed to Maven Central (
attach=false) and add release-staging checks to fail fast if expected dist artifacts are missing. - Improve
tika-appbatch/async invocation behavior with a clearer error message and update CLI documentation/examples accordingly.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tika-server/tika-server-standard/src/main/assembly/assembly.xml |
Removes tgz output format, leaving zip as the distribution format. |
tika-server/tika-server-standard/pom.xml |
Sets attach=false for the server bin assembly and adds an install step intended to satisfy downstream consumption. |
tika-eval/tika-eval-app/pom.xml |
Sets attach=false for the eval app distribution zip. |
tika-app/src/main/java/org/apache/tika/cli/TikaCLI.java |
Wraps async/batch invocation to translate NoClassDefFoundError into a user-actionable message. |
tika-app/pom.xml |
Sets attach=false for the tika-app distribution zip. |
pom.xml |
Adds explicit “missing artifact” failures during apache-release staging and validates pipes plugin zip staging count. |
docs/modules/ROOT/pages/using-tika/cli/index.adoc |
Updates CLI docs to reflect zip-based distribution and batch mode usage via tika-app.jar. |
docs/modules/ROOT/pages/pipes/parse-modes.adoc |
Updates CLI examples to use tika-app.jar for batch processor usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+208
to
+215
| deployed to Central nor installed locally. Sibling reactor modules | ||
| declare tika-server-standard:bin:zip as a Maven dep, so install it | ||
| into the local repo at its canonical coordinates to satisfy reactor | ||
| resolution without publishing it to Central. | ||
| --> | ||
| <execution> | ||
| <id>install-server-bin-zip-locally</id> | ||
| <phase>install</phase> |
| + "standalone jar."); | ||
| System.err.println("Download tika-app-<version>.zip, unzip it, and run " | ||
| + "tika-app-<version>.jar from inside the unzipped directory so that the " | ||
| + "adjacent 'lib/' and 'plugins/' directories are on the classpath."); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!