CTR update go version for docker-compose and fix default read/write buffer size for Client and test settings

Author: xiazcy

CHANGELOG.asciidoc

@@ -42,6 +42,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 * Change signature of `hasId(P<Object>)` and `hasValue(P<Object>)` to `hasId(P<?>)` and `hasValue(P<?>)`.
 * Improved error message for when `emit()` is used without `repeat()`.
 * Changed `PythonTranslator` to generate snake case step naming instead of camel case.
+* Changed `gremlin-go` Client `ReadBufferSize` and `WriteBufferSize` defaults to 1048576 (1MB) to align with DriverRemoteConnection.
 * Fixed bug in `IndexStep` which prevented Java serialization due to non-serializable lambda usage by creating serializable function classes.
 
 [[release-3-7-3]]

gremlin-go/docker-compose.yml

@@ -45,7 +45,7 @@ services:
 
   gremlin-go-integration-tests:
     container_name: gremlin-go-integration-tests
-    image: golang:1.21
+    image: golang:1.22
     volumes:
       - .:/go_app
       - ../gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features:/gremlin-test

gremlin-go/driver/client.go

@@ -79,11 +79,8 @@ func NewClient(url string, configurations ...func(settings *ClientSettings)) (*C
 		ConnectionTimeout:        connectionTimeoutDefault,
 		EnableCompression:        false,
 		EnableUserAgentOnConnect: true,
-		// ReadBufferSize and WriteBufferSize specify I/O buffer sizes in bytes. If a buffer
-		// size is zero, then a useful default size is used. The I/O buffer sizes
-		// do not limit the size of the messages that can be sent or received.
-		ReadBufferSize:  0,
-		WriteBufferSize: 0,
+		ReadBufferSize:           readBufferSizeDefault,
+		WriteBufferSize:          writeBufferSizeDefault,
 
 		NewConnectionThreshold:       defaultNewConnectionThreshold,
 		MaximumConcurrentConnections: runtime.NumCPU(),

gremlin-go/driver/connection_test.go

@@ -64,8 +64,8 @@ func newDefaultConnectionSettings() *connectionSettings {
 		connectionTimeout:        connectionTimeoutDefault,
 		enableCompression:        false,
 		enableUserAgentOnConnect: true,
-		readBufferSize:           0,
-		writeBufferSize:          0,
+		readBufferSize:           readBufferSizeDefault,
+		writeBufferSize:          writeBufferSizeDefault,
 	}
 }
 

gremlin-go/driver/driverRemoteConnection.go

@@ -85,11 +85,8 @@ func NewDriverRemoteConnection(
 		ConnectionTimeout:        connectionTimeoutDefault,
 		EnableCompression:        false,
 		EnableUserAgentOnConnect: true,
-		// ReadBufferSize and WriteBufferSize specify I/O buffer sizes in bytes. The default is 1048576.
-		// If a buffer size is set zero, then the Gorilla websocket 4096 default size is used. The I/O buffer
-		// sizes do not limit the size of the messages that can be sent or received.
-		ReadBufferSize:  1048576,
-		WriteBufferSize: 1048576,
+		ReadBufferSize:           readBufferSizeDefault,
+		WriteBufferSize:          writeBufferSizeDefault,
 
 		NewConnectionThreshold:       defaultNewConnectionThreshold,
 		MaximumConcurrentConnections: runtime.NumCPU(),

gremlin-go/driver/gorillaTransporter.go

@@ -33,6 +33,12 @@ const writeDeadlineDefault = 3 * time.Second
 const writeChannelSizeDefault = 100
 const connectionTimeoutDefault = 5 * time.Second
 
+// ReadBufferSize and WriteBufferSize specify I/O buffer sizes in bytes. The default is 1048576.
+// If a buffer size is set zero, then the Gorilla websocket 4096 default size is used. The I/O buffer
+// sizes do not limit the size of the messages that can be sent or received.
+const readBufferSizeDefault = 1048576
+const writeBufferSizeDefault = 1048576
+
 // Transport layer that uses gorilla/websocket: https://github.com/gorilla/websocket
 // Gorilla WebSocket is a widely used and stable Go implementation of the WebSocket protocol.
 type gorillaTransporter struct {