TINKERPOP-3023 Expand type syntax in grammar - Remove Vertex - TP4#3138
Merged
Conversation
Treat vertex in GraphTraversal as sugar, convert to id in GremlinLang.
Cole-Greer
commented
Jul 10, 2025
|
|
||
| if isinstance(arg, Vertex): | ||
| return f'new ReferenceVertex({self._arg_as_string(arg.id)},\'{arg.label}\')' | ||
| return f'{self._arg_as_string(arg.id)}' |
Contributor
Author
There was a problem hiding this comment.
Python implements the Vertex to id sugar at the GremlinLang level instead of special cases for V(), from(), to(), and mergeE(). Would we want to copy this same approach for other GLVs as they adopt GremlinLang or is it best to focus the sugar to specific steps?
Contributor
Author
There was a problem hiding this comment.
Opted to implement on an individual step bases
Contributor
Author
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #3133 with changes exclusively for TP4. The primary difference in TP4 is that bytecode has been replaced with GremlinLang, which means that the use of
VertexinV(),from(), andto()is now sugar added by GraphTraversal. These vertices must be converted to their ids when passed into GremlinLang.