Fix bulking behavior in gremlin-go for TP 4.0#3397
Merged
Conversation
…roll during traversal iteration, matching Java/Python/.NET/JS GLV behavior
GumpacG
reviewed
Apr 27, 2026
| totalBulk++ | ||
| } | ||
| } | ||
| assert.Equal(t, int64(5), totalBulk) |
Contributor
There was a problem hiding this comment.
Can you add a check for the amount of traversers as that would confirm that it is getting bulked properly.
Should there be a test for when SetBulkResults(false) where an error should be returned since there are no traversers?
kenhuuu
reviewed
Apr 28, 2026
kenhuuu
reviewed
Apr 28, 2026
Contributor
|
Other than the existing comments from Guian and Ken, everything looks good to me. VOTE +1 (pending comment resolutions) |
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed gremlin-go in TP 4.0 to properly handle bulked result with
bulkResultsrequest option. Bulk counts is now preserved inside Traverser objects, and lazily unroll during traversal iteration, matching Java/Python/.NET/JS behavior.Also updated the relevant docs, and captured the fact that all GLVs will set "bulkResults" to true through DRC, overriding the server's default to not bulk.
VOTE +1