Honor per-request options embedded in a script via with options#3518
Open
kenhuuu wants to merge 1 commit into
Open
Honor per-request options embedded in a script via with options#3518kenhuuu wants to merge 1 commit into
kenhuuu wants to merge 1 commit into
Conversation
The server now applies per-request options set inside a submitted Gremlin string's with(): evaluationTimeout/timeoutMillis, materializeProperties, batchSize, bulkResults, and language, with a single precedence: script embedded with() > request field > (header, bulkResults only) > default. This fixes a regression where a script embedded timeoutMillis was silently ignored on the raw string path. Options are resolved once in Context; batchSize is parsed and validated there, returning 400 Bad Request for a non positive or out of range value rather than stalling result iteration or surfacing an uncaught 500. Validation runs before any transaction begin side effects. g, parameters, and transactionId remain request field/header only, and the obsolete requestId scrape is removed from GremlinScriptChecker. Assisted-by: Claude Code:claude-opus-4-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server now applies per-request options set inside a submitted Gremlin string's with(): evaluationTimeout/timeoutMillis, materializeProperties, batchSize, bulkResults, and language, with a single precedence: script embedded with() > request field > (header, bulkResults only) > default. This fixes a regression where a script embedded timeoutMillis was silently ignored on the raw string path.
Options are resolved once in Context; batchSize is parsed and validated there, returning 400 Bad Request for a non positive or out of range value rather than stalling result iteration or surfacing an uncaught 500. Validation runs before any transaction begin side effects. g, parameters, and transactionId remain request field/header only, and the obsolete requestId scrape is removed from GremlinScriptChecker.
VOTE +1