Fix some review issues

Author: markt-asf

java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

@@ -315,7 +315,7 @@ public int getReplayWindowSize() {
     @Override
     public void setReplayWindowSize(int replayWindowSize) {
         if (replayWindowSize < 1) {
-            throw new IllegalArgumentException("replayWindowSize must be greater than zero");
+            throw new IllegalArgumentException(sm.getString("encryptInterceptor.replayWindow.tooSmall"));
         }
         this.replayWindowSize = replayWindowSize;
     }
@@ -544,7 +544,10 @@ public Long getRemovedMemberHeadValue(Member member) {
         private CyclicTracker createTrackerForMember(Member member) {
             CyclicTracker tracker = new CyclicTracker(replayWindowSize);
             Long headValue = messageNumbersByRemovedMember.remove(member);
-            if (headValue != null) {
+            if (headValue == null) {
+                // This is a new member. First valid message will be 0. Therefore set last message to -1.
+                tracker.track(-1);
+            } else {
                 tracker.track(headValue.longValue());
             }
             return tracker;

java/org/apache/catalina/tribes/group/interceptors/LocalStrings.properties

@@ -25,6 +25,7 @@ encryptInterceptor.decrypt.replay=Failed to decrypt message: replay attack detec
 encryptInterceptor.encrypt.failed=Failed to encrypt message
 encryptInterceptor.init.failed=Failed to initialize EncryptInterceptor
 encryptInterceptor.key.required=Encryption key is required
+encryptInterceptor.replayWindow.tooSmall=replayWindowSize must be greater than zero
 encryptInterceptor.tcpFailureDetector.ordering=EncryptInterceptor must be upstream of TcpFailureDetector. Please re-order EncryptInterceptor to be listed before TcpFailureDetector in your channel interceptor pipeline.
 
 fragmentationInterceptor.fragments.missing=Fragments are missing.

java/org/apache/catalina/tribes/util/CyclicTracker.java

@@ -24,6 +24,8 @@
  */
 public class CyclicTracker {
 
+    private static final StringManager sm = StringManager.getManager(CyclicTracker.class);
+
     private final boolean[] seen;
 
     private boolean initialized = false;
@@ -33,7 +35,7 @@ public class CyclicTracker {
 
     public CyclicTracker(int size) {
         if (size < 1) {
-            throw new IllegalArgumentException("size must be greater than zero");
+            throw new IllegalArgumentException(sm.getString("cyclicTracker.size.tooSmall"));
         }
         seen = new boolean[size];
     }

java/org/apache/catalina/tribes/util/LocalStrings.properties

@@ -18,6 +18,7 @@ arrays.length.outOfBounds=not enough data elements in the key, length is out of
 arrays.malformed.arrays=byte arrays must be represented as {1,3,4,5,6}
 arrays.srcoffset.outOfBounds=srcoffset is out of bounds.
 
+cyclicTracker.size.tooSmall=size must be greater than zero
 executorFactory.not.running=Executor not running, can't force a command into the queues
 executorFactory.queue.full=Queue capacity is full.