Fix a CodeQL warning

markt-asf · markt-asf · commit 5440280d691b · 2026-05-14T13:49:59.000+01:00
Ensures sub-classes override equals (the current ones do).
diff --git a/java/org/apache/tomcat/util/buf/AbstractChunk.java b/java/org/apache/tomcat/util/buf/AbstractChunk.java
@@ -241,6 +241,15 @@ public int hashCode() {
     }
 
 
+    /**
+     * {@inheritDoc}
+     * <p>
+     * Sub-classes must provide an equals implementation that is consistent with {@link AbstractChunk#hashCode()}.
+     */
+    @Override
+    public abstract boolean equals(Object obj);
+
+
     /**
      * Returns the hash code for this buffer.
      *

Original file line number	Diff line number	Diff line change
`@@ -241,6 +241,15 @@ public int hashCode() {`
`241`	`241`	`}`
`242`	`242`
`243`	`243`
	`244`	`+ /**`
	`245`	`+ * {@inheritDoc}`
	`246`	`+ * <p>`
	`247`	`+ * Sub-classes must provide an equals implementation that is consistent with {@link AbstractChunk#hashCode()}.`
	`248`	`+ */`
	`249`	`+ @Override`
	`250`	`+ public abstract boolean equals(Object obj);`
	`251`	`+`
	`252`	`+`
`244`	`253`	`/**`
`245`	`254`	`* Returns the hash code for this buffer.`
`246`	`255`	`*`