Restore extending classes

Author: rmaucher

java/org/apache/catalina/valves/AbstractAccessLogValve.java

@@ -876,7 +876,7 @@ protected static class ThreadNameElement implements AccessLogElement {
         /**
          * Constructs a new ThreadNameElement.
          */
-        ThreadNameElement() {
+        public ThreadNameElement() {
         }
 
         /**
@@ -1015,7 +1015,7 @@ protected class HostElement implements AccessLogElement, CachedElement {
         /**
          * Constructs a new HostElement.
          */
-        HostElement() {
+        public HostElement() {
         }
 
         /**
@@ -1064,7 +1064,7 @@ protected static class LogicalUserNameElement implements AccessLogElement {
         /**
          * Constructs a new LogicalUserNameElement.
          */
-        LogicalUserNameElement() {
+        public LogicalUserNameElement() {
         }
 
         /**
@@ -1089,7 +1089,7 @@ protected class ProtocolElement implements AccessLogElement {
         /**
          * Constructs a new ProtocolElement.
          */
-        ProtocolElement() {
+        public ProtocolElement() {
         }
 
         /**
@@ -1123,7 +1123,7 @@ protected static class UserElement implements AccessLogElement {
         /**
          * Constructs a new UserElement.
          */
-        UserElement() {
+        public UserElement() {
         }
 
         /**
@@ -1199,7 +1199,7 @@ protected class DateAndTimeElement implements AccessLogElement {
         /**
          * Creates a new date and time element using CLF format.
          */
-        protected DateAndTimeElement() {
+        public DateAndTimeElement() {
             this(null);
         }
 
@@ -1237,7 +1237,7 @@ private String tidyFormat(String format) {
          *
          * @param sdf The SimpleDateFormat pattern or special format identifier
          */
-        protected DateAndTimeElement(String sdf) {
+        public DateAndTimeElement(String sdf) {
             String format = sdf;
             boolean needsEscaping = false;
             if (sdf != null) {
@@ -1345,7 +1345,7 @@ protected static class RequestElement implements AccessLogElement {
         /**
          * Constructs a new RequestElement.
          */
-        RequestElement() {
+        public RequestElement() {
         }
 
         /**
@@ -1385,7 +1385,7 @@ protected static class HttpStatusCodeElement implements AccessLogElement {
         /**
          * Constructs a new HttpStatusCodeElement.
          */
-        HttpStatusCodeElement() {
+        public HttpStatusCodeElement() {
         }
 
         /**
@@ -1534,7 +1534,7 @@ protected static class MethodElement implements AccessLogElement {
         /**
          * Constructs a new MethodElement.
          */
-        MethodElement() {
+        public MethodElement() {
         }
 
         /**
@@ -1663,7 +1663,7 @@ protected static class FirstByteTimeElement implements AccessLogElement {
         /**
          * Constructs a new FirstByteTimeElement.
          */
-        FirstByteTimeElement() {
+        public FirstByteTimeElement() {
         }
 
         /**
@@ -1694,7 +1694,7 @@ protected static class QueryElement implements AccessLogElement {
         /**
          * Constructs a new QueryElement.
          */
-        QueryElement() {
+        public QueryElement() {
         }
 
         /**
@@ -1747,7 +1747,7 @@ protected static class SessionIdElement implements AccessLogElement {
         /**
          * Constructs a new SessionIdElement.
          */
-        SessionIdElement() {
+        public SessionIdElement() {
         }
 
         /**
@@ -1781,7 +1781,7 @@ protected static class RequestURIElement implements AccessLogElement {
         /**
          * Constructs a new RequestURIElement.
          */
-        RequestURIElement() {
+        public RequestURIElement() {
         }
 
         /**
@@ -1810,7 +1810,7 @@ protected class LocalServerNameElement implements AccessLogElement {
         /**
          * Constructs a new LocalServerNameElement.
          */
-        LocalServerNameElement() {
+        public LocalServerNameElement() {
         }
 
         /**
@@ -2051,7 +2051,7 @@ protected static class ConnectionStatusElement implements AccessLogElement {
         /**
          * Constructs a new ConnectionStatusElement.
          */
-        ConnectionStatusElement() {
+        public ConnectionStatusElement() {
         }
 
         /**

webapps/docs/changelog.xml

@@ -229,6 +229,10 @@
       <fix>
         Avoid NPE in RewriteValve. (markt)
       </fix>
+      <fix>
+        Restore ability to extend many element classes from
+        <code>AbstractAccessLogValve</code>. (remm)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">