Skip to content

Commit efb8b99

Browse files
committed
Comment out tests rather than use @ignore
Avoids triggering 'skipped tests' messages in test output
1 parent 6b90c06 commit efb8b99

1 file changed

Lines changed: 15 additions & 7 deletions

File tree

test/org/apache/el/parser/TestELParserPerformance.java

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import jakarta.el.ValueExpression;
3030

3131
import org.junit.Assert;
32-
import org.junit.Ignore;
3332
import org.junit.Test;
3433

3534
import org.apache.tomcat.util.collections.SynchronizedStack;
@@ -99,9 +98,12 @@ public void testParserInstanceReuse() throws ParseException {
9998
/*
10099
* Ignored by default since this is an absolute test primarily for
101100
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69338
101+
*
102+
* Comment out @Test rather than use @Ignore since @Ignore triggers a "skipped test" message in the test output
103+
* and those messages should be reserved for tests skipped due to environmental (no APR, wrong Java version, etc)
104+
* issues.
102105
*/
103-
@Ignore
104-
@Test
106+
//@Test
105107
public void testAstAnd() {
106108

107109
ELManager manager = new ELManager();
@@ -145,9 +147,12 @@ public void testAstAnd() {
145147
/*
146148
* Ignored by default since this is an absolute test primarily for
147149
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69338
150+
*
151+
* Comment out @Test rather than use @Ignore since @Ignore triggers a "skipped test" message in the test output
152+
* and those messages should be reserved for tests skipped due to environmental (no APR, wrong Java version, etc)
153+
* issues.
148154
*/
149-
@Ignore
150-
@Test
155+
//@Test
151156
public void testAstNotEmpty() {
152157

153158
ELManager manager = new ELManager();
@@ -214,9 +219,12 @@ private Object runTest(Callable<Object> c, String description) throws Exception
214219
*
215220
* Ignored by default since this is an absolute test primarily for
216221
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69381
222+
*
223+
* Comment out @Test rather than use @Ignore since @Ignore triggers a "skipped test" message in the test output
224+
* and those messages should be reserved for tests skipped due to environmental (no APR, wrong Java version, etc)
225+
* issues.
217226
*/
218-
@Ignore
219-
@Test
227+
//@Test
220228
public void testExpressions() throws Exception {
221229

222230
ELManager manager = new ELManager();

0 commit comments

Comments
 (0)