Skip to content

Commit 12fdb07

Browse files
authored
Fixx autest tls_sni_ticket so it can work with BoringSSL (#13100)
The per-SNI override is unavailable with BoringSSL. The expected number of tickets should be different for BoringSSL.
1 parent 2dde15e commit 12fdb07

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

tests/gold_tests/tls/tls_sni_ticket.test.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,10 +217,21 @@ def add_tls13_enabled_run(self) -> None:
217217
f'openssl s_client -connect 127.0.0.1:{self.ts_on.Variables.ssl_port} -servername tickets-on.com -tls1_3 -msg -ign_eof')
218218
tr.ReturnCode = 0
219219
self.start_processes_if_needed(tr, start_server=True, start_ts_on=True)
220+
221+
# BoringSSL only exposes SSL_CTX_set_num_tickets() (context-level),
222+
# not SSL_set_num_tickets() (per-connection), so the per-SNI
223+
# ssl_ticket_number override cannot change the ticket count. The
224+
# CTX-level value for ts_on is 0, so expect 0 tickets.
225+
if Condition.IsBoringSSL():
226+
expected_count = 0
227+
description = 'Check that tickets-on.com receives no TLSv1.3 tickets (BoringSSL ignores per-SNI ticket count)'
228+
else:
229+
expected_count = 3
230+
description = 'Check that tickets-on.com receives three TLSv1.3 tickets'
231+
220232
tr.Processes.Default.Streams.All.Content = Testers.Lambda(
221233
lambda info, tester: TlsSniTicketTest.check_regex_count(
222-
tr.Processes.Default.Streams.All.AbsPath, r'NewSessionTicket', 3,
223-
'Check that tickets-on.com receives three TLSv1.3 tickets'))
234+
tr.Processes.Default.Streams.All.AbsPath, r'NewSessionTicket', expected_count, description))
224235
tr.StillRunningAfter += self.server
225236
tr.StillRunningAfter += self.ts_on
226237

0 commit comments

Comments
 (0)