Skip to content

Commit 4558d1d

Browse files
authored
Remove unused VIO.op values (#12186)
These values are in the enum, but are not used anywhere in the code. Remove the unused values and the confusing documentation.
1 parent 69466fd commit 4558d1d

2 files changed

Lines changed: 3 additions & 25 deletions

File tree

include/iocore/eventsystem/VIO.h

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,6 @@ class ProxyMutex;
5050
</tr>
5151
<tr><td>READ</td><td>The VIO represents a read operation</td></tr>
5252
<tr><td>WRITE</td><td>The VIO represents a write operation</td></tr>
53-
<tr><td>CLOSE</td><td>The VIO represents the request to close the
54-
VConnection</td></tr>
55-
<tr><td>ABORT</td><td></td></tr>
56-
<tr><td>SHUTDOWN_READ</td><td></td></tr>
57-
<tr><td>SHUTDOWN_WRITE</td><td></td></tr>
58-
<tr><td>SHUTDOWN_READWRITE</td><td></td></tr>
59-
<tr><td>SEEK</td><td></td></tr>
60-
<tr><td>PREAD</td><td></td></tr>
61-
<tr><td>PWRITE</td><td></td></tr>
62-
<tr><td>STAT</td><td></td></tr>
6353
</table>
6454
6555
*/
@@ -142,15 +132,6 @@ class VIO
142132
NONE = 0,
143133
READ,
144134
WRITE,
145-
CLOSE,
146-
ABORT,
147-
SHUTDOWN_READ,
148-
SHUTDOWN_WRITE,
149-
SHUTDOWN_READWRITE,
150-
SEEK,
151-
PREAD,
152-
PWRITE,
153-
STAT,
154135
};
155136

156137
/**

include/iocore/net/NetVConnection.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,10 @@ class NetVConnection : public VConnection, public PluginUserArgs<TS_USER_ARGS_VC
129129
called, the VConnection and underlying processor must NOT send
130130
any more events related to this VConnection to the state machine.
131131
Likewise, state machine must not access the VConnection or
132-
any returned VIOs after calling close. lerrno indicates whether
133-
a close is a normal close or an abort. The difference between
134-
a normal close and an abort depends on the underlying type of
135-
the VConnection. Passing VIO::CLOSE for lerrno indicates a
136-
normal close while passing VIO::ABORT indicates an abort.
132+
any returned VIOs after calling close. lerrno indicates the last
133+
error on the NetVConnection.
137134
138-
@param lerrno VIO:CLOSE for regular close or VIO::ABORT for aborts
135+
@param lerrno Last error on the NetVConnection
139136
140137
*/
141138
void do_io_close(int lerrno = -1) override = 0;

0 commit comments

Comments
 (0)