Skip to content

Commit 5b7ab92

Browse files
authored
Guard HTTP/3 test targets with BUILD_TESTING (#13094)
Guard add_catch2_test for h3 with BUILD_TESTING. Otherwise -DBUILD_TESTING=off fails when HTTP/3 builds are enabled.
1 parent 8e6b509 commit 5b7ab92

1 file changed

Lines changed: 38 additions & 36 deletions

File tree

src/proxy/http3/CMakeLists.txt

Lines changed: 38 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -47,42 +47,44 @@ target_link_libraries(
4747
PRIVATE ts::proxy
4848
)
4949

50-
add_executable(
51-
test_http3
52-
test/main.cc
53-
test/stub.cc
54-
test/test_Http3Frame.cc
55-
test/test_Http3FrameDispatcher.cc
56-
Http3ProtocolEnforcer.cc
57-
Http3FrameDispatcher.cc
58-
Http3DebugNames.cc
59-
Http3Config.cc
60-
Http3Frame.cc
61-
Http3SettingsHandler.cc
62-
)
63-
target_link_libraries(
64-
test_http3
65-
PRIVATE Catch2::Catch2WithMain
66-
ts::quic
67-
ts::inkevent
68-
ts::records
69-
ts::tsutil
70-
ts::hdrs
71-
ts::tscore
72-
)
73-
add_catch2_test(NAME test_http3 COMMAND test_http3)
50+
if(BUILD_TESTING)
51+
add_executable(
52+
test_http3
53+
test/main.cc
54+
test/stub.cc
55+
test/test_Http3Frame.cc
56+
test/test_Http3FrameDispatcher.cc
57+
Http3ProtocolEnforcer.cc
58+
Http3FrameDispatcher.cc
59+
Http3DebugNames.cc
60+
Http3Config.cc
61+
Http3Frame.cc
62+
Http3SettingsHandler.cc
63+
)
64+
target_link_libraries(
65+
test_http3
66+
PRIVATE Catch2::Catch2WithMain
67+
ts::quic
68+
ts::inkevent
69+
ts::records
70+
ts::tsutil
71+
ts::hdrs
72+
ts::tscore
73+
)
74+
add_catch2_test(NAME test_http3 COMMAND test_http3)
7475

75-
add_executable(test_qpack test/main_qpack.cc test/test_QPACK.cc QPACK.cc)
76-
target_link_libraries(
77-
test_qpack
78-
PRIVATE Catch2::Catch2
79-
ts::quic
80-
ts::inkevent
81-
ts::records
82-
ts::tsutil
83-
ts::hdrs
84-
ts::tscore
85-
)
86-
add_catch2_test(NAME test_qpack COMMAND test_qpack)
76+
add_executable(test_qpack test/main_qpack.cc test/test_QPACK.cc QPACK.cc)
77+
target_link_libraries(
78+
test_qpack
79+
PRIVATE Catch2::Catch2
80+
ts::quic
81+
ts::inkevent
82+
ts::records
83+
ts::tsutil
84+
ts::hdrs
85+
ts::tscore
86+
)
87+
add_catch2_test(NAME test_qpack COMMAND test_qpack)
88+
endif()
8789

8890
clang_tidy_check(http3)

0 commit comments

Comments
 (0)