Cleanup: HttpTransact::StateMachineAction_t (#12533)

Author: masaori335

include/proxy/http/HttpTransact.h

@@ -388,7 +388,6 @@ class HttpTransact
 
     ORIGIN_SERVER_OPEN,
     ORIGIN_SERVER_RAW_OPEN,
-    ORIGIN_SERVER_RR_MARK_DOWN,
 
     READ_PUSH_HDR,
     STORE_PUSH_BODY,
@@ -407,7 +406,6 @@ class HttpTransact
     SERVER_PARSE_NEXT_HDR,
     TRANSFORM_READ,
     SSL_TUNNEL,
-    CONTINUE,
 
     API_SM_START,
     API_READ_REQUEST_HDR,

src/proxy/http/HttpDebugNames.cc

@@ -398,9 +398,6 @@ HttpDebugNames::get_action_name(HttpTransact::StateMachineAction_t e)
   case HttpTransact::StateMachineAction_t::ORIGIN_SERVER_RAW_OPEN:
     return ("StateMachineAction_t::ORIGIN_SERVER_RAW_OPEN");
 
-  case HttpTransact::StateMachineAction_t::ORIGIN_SERVER_RR_MARK_DOWN:
-    return ("StateMachineAction_t::ORIGIN_SERVER_RR_MARK_DOWN");
-
   case HttpTransact::StateMachineAction_t::READ_PUSH_HDR:
     return ("StateMachineAction_t::READ_PUSH_HDR");
 
@@ -431,9 +428,6 @@ HttpDebugNames::get_action_name(HttpTransact::StateMachineAction_t e)
   case HttpTransact::StateMachineAction_t::SSL_TUNNEL:
     return ("StateMachineAction_t::SSL_TUNNEL");
 
-  case HttpTransact::StateMachineAction_t::CONTINUE:
-    return ("StateMachineAction_t::CONTINUE");
-
   case HttpTransact::StateMachineAction_t::API_READ_REQUEST_HDR:
     return ("StateMachineAction_t::API_READ_REQUEST_HDR");
 

src/proxy/http/HttpSM.cc

@@ -8243,21 +8243,6 @@ HttpSM::set_next_state()
     break;
   }
 
-  case HttpTransact::StateMachineAction_t::ORIGIN_SERVER_RR_MARK_DOWN: {
-    HTTP_SM_SET_DEFAULT_HANDLER(&HttpSM::state_mark_os_down);
-    ATS_PROBE(next_state_SM_ACTION_ORIGIN_SERVER_RR_MARK_DOWN);
-
-    ink_assert(t_state.dns_info.looking_up == ResolveInfo::ORIGIN_SERVER);
-
-    // TODO: This might not be optimal (or perhaps even correct), but it will
-    // effectively mark the host as down. What's odd is that state_mark_os_down
-    // above isn't triggering.
-    HttpSM::do_hostdb_update_if_necessary();
-
-    do_hostdb_lookup();
-    break;
-  }
-
   case HttpTransact::StateMachineAction_t::SSL_TUNNEL: {
     t_state.api_next_action = HttpTransact::StateMachineAction_t::API_SEND_RESPONSE_HDR;
     do_api_callout();
@@ -8332,11 +8317,6 @@ HttpSM::set_next_state()
     break;
   }
 
-  case HttpTransact::StateMachineAction_t::CONTINUE: {
-    ink_release_assert(!"Not implemented");
-    break;
-  }
-
   default: {
     ink_release_assert(!"Unknown next action");
   }