Address review: fix EPERM/EOPNOTSUPP entries, add errno name test

The FreeBSD table was missing EPERM (errno 1), so it formatted as
"Unknown". Linux and FreeBSD also picked the ENOTSUP alias over the
more common EOPNOTSUPP for that value, which changed existing log
output. Prefer the canonical name (EAGAIN/EDEADLK/EOPNOTSUPP) and fill
in EPERM.

Add a test_bw_format case asserting bwf::Errno prints the platform's
own symbolic name for EPERM, ETIMEDOUT, and ECONNREFUSED, guarding
against the mislabel this PR fixes.

Author: bryancall

lib/swoc/src/bw_format.cc

@@ -763,7 +763,7 @@ static constexpr std::string_view ERRNO_NAMES[] = {
   /*  64 */ "ENONET", "ENOPKG", "EREMOTE", "ENOLINK", "EADV", "ESRMNT", "ECOMM", "EPROTO",
   /*  72 */ "EMULTIHOP", "EDOTDOT", "EBADMSG", "EOVERFLOW", "ENOTUNIQ", "EBADFD", "EREMCHG", "ELIBACC",
   /*  80 */ "ELIBBAD", "ELIBSCN", "ELIBMAX", "ELIBEXEC", "EILSEQ", "ERESTART", "ESTRPIPE", "EUSERS",
-  /*  88 */ "ENOTSOCK", "EDESTADDRREQ", "EMSGSIZE", "EPROTOTYPE", "ENOPROTOOPT", "EPROTONOSUPPORT", "ESOCKTNOSUPPORT", "ENOTSUP",
+  /*  88 */ "ENOTSOCK", "EDESTADDRREQ", "EMSGSIZE", "EPROTOTYPE", "ENOPROTOOPT", "EPROTONOSUPPORT", "ESOCKTNOSUPPORT", "EOPNOTSUPP",
   /*  96 */ "EPFNOSUPPORT", "EAFNOSUPPORT", "EADDRINUSE", "EADDRNOTAVAIL", "ENETDOWN", "ENETUNREACH", "ENETRESET", "ECONNABORTED",
   /* 104 */ "ECONNRESET", "ENOBUFS", "EISCONN", "ENOTCONN", "ESHUTDOWN", "ETOOMANYREFS", "ETIMEDOUT", "ECONNREFUSED",
   /* 112 */ "EHOSTDOWN", "EHOSTUNREACH", "EALREADY", "EINPROGRESS", "ESTALE", "EUCLEAN", "ENOTNAM", "ENAVAIL",
@@ -789,12 +789,12 @@ static constexpr std::string_view ERRNO_NAMES[] = {
 };
 #elif defined(__FreeBSD__)
 static constexpr std::string_view ERRNO_NAMES[] = {
-  /*   0 */ "SUCCESS", "", "ENOENT", "ESRCH", "EINTR", "EIO", "ENXIO", "E2BIG",
+  /*   0 */ "SUCCESS", "EPERM", "ENOENT", "ESRCH", "EINTR", "EIO", "ENXIO", "E2BIG",
   /*   8 */ "ENOEXEC", "EBADF", "ECHILD", "EDEADLK", "ENOMEM", "EACCES", "EFAULT", "ENOTBLK",
   /*  16 */ "EBUSY", "EEXIST", "EXDEV", "ENODEV", "ENOTDIR", "EISDIR", "EINVAL", "ENFILE",
   /*  24 */ "EMFILE", "ENOTTY", "ETXTBSY", "EFBIG", "ENOSPC", "ESPIPE", "EROFS", "EMLINK",
   /*  32 */ "EPIPE", "EDOM", "ERANGE", "EAGAIN", "EINPROGRESS", "EALREADY", "ENOTSOCK", "EDESTADDRREQ",
-  /*  40 */ "EMSGSIZE", "EPROTOTYPE", "ENOPROTOOPT", "EPROTONOSUPPORT", "ESOCKTNOSUPPORT", "ENOTSUP", "EPFNOSUPPORT", "EAFNOSUPPORT",
+  /*  40 */ "EMSGSIZE", "EPROTOTYPE", "ENOPROTOOPT", "EPROTONOSUPPORT", "ESOCKTNOSUPPORT", "EOPNOTSUPP", "EPFNOSUPPORT", "EAFNOSUPPORT",
   /*  48 */ "EADDRINUSE", "EADDRNOTAVAIL", "ENETDOWN", "ENETUNREACH", "ENETRESET", "ECONNABORTED", "ECONNRESET", "ENOBUFS",
   /*  56 */ "EISCONN", "ENOTCONN", "ESHUTDOWN", "ETOOMANYREFS", "ETIMEDOUT", "ECONNREFUSED", "ELOOP", "ENAMETOOLONG",
   /*  64 */ "EHOSTDOWN", "EHOSTUNREACH", "ENOTEMPTY", "EPROCLIM", "EUSERS", "EDQUOT", "ESTALE", "EREMOTE",

lib/swoc/unit_tests/test_bw_format.cc

@@ -8,6 +8,7 @@
 #include <iostream>
 #include <variant>
 #include <cmath>
+#include <cerrno>
 
 #include <netinet/in.h>
 
@@ -545,6 +546,18 @@ TEST_CASE("bwstring std formats", "[libswoc][bwprint]") {
   w.clear().print("{::l}", swoc::bwf::Errno(13));
   REQUIRE(w.view() == "Permission denied [13]"sv);
 
+  // The symbolic short name must come from the running platform's <errno.h>,
+  // not a fixed Linux-numbered table. Regression guard for the FreeBSD/macOS
+  // mislabel where ETIMEDOUT (errno 60 on those platforms) printed as "ENOSTR"
+  // (apache/trafficserver#13203). Use the macros so each platform checks its
+  // own numbering.
+  w.clear().print("{:s:s}", swoc::bwf::Errno(EPERM));
+  REQUIRE(w.view() == "EPERM"sv);
+  w.clear().print("{:s:s}", swoc::bwf::Errno(ETIMEDOUT));
+  REQUIRE(w.view() == "ETIMEDOUT"sv);
+  w.clear().print("{:s:s}", swoc::bwf::Errno(ECONNREFUSED));
+  REQUIRE(w.view() == "ECONNREFUSED"sv);
+
   time_t t = 1528484137;
   // default is GMT
   w.clear().print("{} is {}", t, swoc::bwf::Date(t));