hrw4u: disallow inbound.url.{} as an operator#13121
Open
mlibbey wants to merge 1 commit intoapache:masterfrom
Open
hrw4u: disallow inbound.url.{} as an operator#13121mlibbey wants to merge 1 commit intoapache:masterfrom
mlibbey wants to merge 1 commit intoapache:masterfrom
Conversation
When one uses inbound.url.{} as an operator, for instance:
REMAP {
inbound.url.host = "example.com";
}
hrw4u turns this into set-destination which modifies the outbound URL,
making the naming actively misleading.
inbound.url reads from the pristine client URL (CLIENT-URL) which
is immutable — ATS provides no mechanism to set it. So, removing this
as an operator, but keeping it as a valid condition.
mlibbey
force-pushed
the
hrw4u-inbound-url-operator-removal
branch
from
7e4119a to
35d44a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one uses inbound.url.{} as an operator, for instance: REMAP {
inbound.url.host = "example.com";
}
hrw4u turns this into set-destination which modifies the outbound URL, making the naming actively misleading.
inbound.url reads from the pristine client URL (CLIENT-URL) which is immutable — ATS provides no mechanism to set it. So, removing this as an operator, but keeping it as a valid condition.