Skip to content

[ADDON] Add torch c dlpack ext wheels for windows#252

Merged
tqchen merged 44 commits into
apache:mainfrom
cyx-6:torch-c-dlpack-windows
Nov 10, 2025
Merged

[ADDON] Add torch c dlpack ext wheels for windows#252
tqchen merged 44 commits into
apache:mainfrom
cyx-6:torch-c-dlpack-windows

Conversation

@cyx-6

@cyx-6 cyx-6 commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

This PR adds the torch c dlpack ext wheels for windows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @cyx-6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the build process for the torch_c_dlpack_ext addon by introducing a dedicated Windows batch script for AOT wheel generation. It addresses critical Windows-specific build challenges, such as properly handling file paths with spaces and ensuring correct linking of CUDA libraries, thereby enabling robust and automated wheel creation for various PyTorch versions on the Windows platform.

Highlights

  • New Windows Build Script: A new batch script (build_aot_wheels.bat) has been added to automate the building of Ahead-Of-Time (AOT) wheels for the torch_c_dlpack_ext addon on Windows, supporting various PyTorch versions.
  • Improved Include Path Handling: The build utility now correctly handles include paths on Windows, specifically by quoting paths that contain spaces and ensuring proper drive letter formatting, preventing potential build failures.
  • Corrected CUDA Linker Flags for Windows: The linker flags for CUDA-enabled builds on Windows have been updated to explicitly include torch_cuda.lib and c10_cuda.lib, resolving linking issues when building with CUDA support.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/torch_c_dlpack.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Windows batch script to build torch_c_dlpack_ext wheels, along with necessary adjustments in the Python build utility. The changes in the Python script for handling Windows paths and CUDA libraries are correct. The new batch script is functional, but I've identified a few areas for improvement to enhance its robustness and maintainability. Specifically, I'm suggesting changes to handle directory creation idempotently, remove an unnecessary package dependency for Windows, and refactor a section for better readability.

Comment thread addons/torch_c_dlpack_ext/build_aot_wheels.bat
Comment thread addons/torch_c_dlpack_ext/build_aot_wheels.bat Outdated
Comment thread addons/torch_c_dlpack_ext/build_aot_wheels.bat Outdated
@tqchen tqchen merged commit d1595c4 into apache:main Nov 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants