[ADDON] Add torch c dlpack ext wheels for windows#252
Conversation
Summary of ChangesHello @cyx-6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the build process for the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a Windows batch script to build torch_c_dlpack_ext wheels, along with necessary adjustments in the Python build utility. The changes in the Python script for handling Windows paths and CUDA libraries are correct. The new batch script is functional, but I've identified a few areas for improvement to enhance its robustness and maintainability. Specifically, I'm suggesting changes to handle directory creation idempotently, remove an unnecessary package dependency for Windows, and refactor a section for better readability.
This PR adds the torch c dlpack ext wheels for windows.