[Relax][ONNX] Set max_output_boxes_per_class default value to 0 for NonMaxSuppression#19547
Open
cchung100m wants to merge 3 commits into
Open
[Relax][ONNX] Set max_output_boxes_per_class default value to 0 for NonMaxSuppression#19547cchung100m wants to merge 3 commits into
max_output_boxes_per_class default value to 0 for NonMaxSuppression#19547cchung100m wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default value for max_output_boxes_per_class from 100 to 0 in the ONNX frontend to align with the ONNX specification. Feedback suggests that AllClassNMS._impl_v1 should also be updated to use 0 as the default value to maintain consistency across the codebase.
Comment on lines
+4760
to
+4762
| max_output_boxes_per_class = 0 # Default value | ||
| else: | ||
| max_output_boxes_per_class = 100 # Default value | ||
| max_output_boxes_per_class = 0 # Default value |
Contributor
There was a problem hiding this comment.
The default value for max_output_boxes_per_class is updated to 0 here to align with the ONNX specification. However, AllClassNMS._impl_v1 (lines 4849 and 4851) still uses 100 as the default value. To maintain consistency across the ONNX frontend, AllClassNMS should also be updated to use 0 as the default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Committers,
This PR is trying to fix issues #19544. Any suggestions would be appreciated if you are available.