[REFACTOR][TIRX] Add IntImm common scalar ctor and streamline MakeConst#19797
Merged
tqchen merged 1 commit intoJun 17, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to use direct IntImm and FloatImm constructors (such as IntImm::Int32, IntImm::Int64, and IntImm::Bool) instead of the generic make_const or make_zero helpers when the data type is statically known to be a scalar. This change improves compilation efficiency and code compactness. The review feedback identifies several remaining instances across the codebase—specifically in loop vectorization, interval set operations, affine map iterations, double buffer injection, and FFI binding—where make_const is still being used for scalar types, and suggests replacing them with direct IntImm calls to complete the refactoring consistently.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tqchen
changed the title
tqchen
force-pushed
the
tvm-add-intimm-common-scalar-constructors-and-migrate-uses
branch
3 times, most recently
from
2cc64e5 to
ddfe920
Compare
spectrometerHBH
approved these changes
Jun 16, 2026
tqchen
changed the title
tqchen
force-pushed
the
tvm-add-intimm-common-scalar-constructors-and-migrate-uses
branch
3 times, most recently
from
bdc150c to
7ab7b0a
Compare
Common bool, int32, and int64 scalar constants show up throughout TIRX and related lowering code, and named constructors make these call sites easier to read than repeated DataType spelling. This PR establishes the scalar-constant construction policy and renames make_const to MakeConst to match the public helper naming style. - Prefer IntImm::Bool, IntImm::Int32, and IntImm::Int64 for common known scalar bool, int32, and int64 constants. - Prefer direct IntImm or FloatImm construction when dtype is known to be scalar integer or floating point. This makes the compiled code more compact and efficient. Keep MakeConst for generic overload cases where dtype can be integer, floating point, or vector-valued and the caller needs its scalar/vector dispatch. - Phase out make_zero in favor of explicit scalar constructors, or ConstHandle(0) for null handles.
tqchen
force-pushed
the
tvm-add-intimm-common-scalar-constructors-and-migrate-uses
branch
from
7ab7b0a to
9958ebe
Compare
Member
Author
|
@tvm-bot rerun |
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 16, 2026
…st (apache#19797) Common bool, int32, and int64 scalar constants show up throughout TIRX and related lowering code, and named constructors make these call sites easier to read than repeated DataType spelling. This PR establishes the scalar-constant construction policy and renames make_const to MakeConst to match the public helper naming style. - Prefer IntImm::Bool, IntImm::Int32, and IntImm::Int64 for common known scalar bool, int32, and int64 constants. - Prefer direct IntImm or FloatImm construction when dtype is known to be scalar integer or floating point. This makes the compiled code more compact and efficient. Keep MakeConst for generic overload cases where dtype can be integer, floating point, or vector-valued and the caller needs its scalar/vector dispatch. - Phase out make_zero in favor of explicit scalar constructors, or ConstHandle(0) for null handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Common bool, int32, and int64 scalar constants show up throughout TIRX and related lowering code. Named constructors make these call sites easier to read than repeated
DataTypespelling, and avoid routing obvious scalar constants through the genericMakeConsthelper.Usage guideline
Prefer direct
IntImmorFloatImmconstruction when dtype is known to be scalar integer or floating point. This makes the compiled code more compact and efficient. KeepMakeConstfor generic overload cases where dtype can be integer, floating point, or vector-valued and the caller needs its scalar/vector dispatch.This PR establishes the scalar-constant construction policy:
IntImm::Bool,IntImm::Int32, andIntImm::Int64for common known scalar bool, int32, and int64 constants.IntImmorFloatImmconstruction when dtype is known to be scalar integer or floating point.MakeConstfor generic overload cases where dtype can be integer, floating point, or vector-valued and the caller needs its scalar/vector dispatch.make_zeroin favor of explicit scalar constructors, orConstHandle(0)for null handles.Changes
IntImm::Bool,IntImm::Int32, andIntImm::Int64helpers.make_consttoMakeConstand document it as the generic/vector construction helper.MakeConst.make_zero,const_true,const_false, and the unusedtirx.const_trueregistry entry.