Skip to content

[Docs] Right-align documentation footer#19868

Merged
tqchen merged 1 commit into
apache:mainfrom
tlopex:mine/docs/right-align-footer
Jun 23, 2026
Merged

[Docs] Right-align documentation footer#19868
tqchen merged 1 commit into
apache:mainfrom
tlopex:mine/docs/right-align-footer

Conversation

@tlopex

@tlopex tlopex commented Jun 23, 2026

Copy link
Copy Markdown
Member

This PR right-aligns the custom documentation footer added with the sphinx-book-theme migration.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the footer layout in docs/conf.py to align its content (links, dropdown, and notes) to the right instead of centering it, while also enabling wrapping. The review feedback correctly points out that right-aligning the footer could cause the dropdown menu to overflow the right edge of the viewport, and suggests adding the dropdown-menu-end class to ensure proper alignment.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/conf.py
<div class="footer-container" style="margin: 5px 0; font-size: 0.9em; color: #6c757d;">
<div class="footer-line1" style="display: flex; justify-content: center; align-items: center; gap: 0.9em; margin-bottom: 3px;">
<div class="footer-container" style="margin: 5px 0; font-size: 0.9em; color: #6c757d; text-align: right;">
<div class="footer-line1" style="display: flex; justify-content: flex-end; align-items: center; gap: 0.9em; margin-bottom: 3px; flex-wrap: wrap;">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the footer is now right-aligned, the dropdown menu (located on line 423) will likely overflow the right edge of the viewport when opened, as Bootstrap dropdowns align to the left by default.

To prevent this, consider adding the dropdown-menu-end class to the dropdown menu <ul> element on line 423:

<ul class="dropdown-menu dropdown-menu-end" aria-labelledby="footerDropdown" style="font-size: 0.9em;">

@tqchen tqchen merged commit 4a70d96 into apache:main Jun 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants