[CI] Stop building ci_lint Docker image#19872
Open
tlopex wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the ci_lint Docker image and its associated setup scripts, updating the Jenkins pipeline files and local scripts to run linting locally via pre-commit instead of inside a dedicated container. The reviewer noted that the fix parameter in the lint function in tests/scripts/ci.py is now unused and should be removed from the function signature and docstring.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
f5dc46d to
9fa7c0b
Compare
9fa7c0b to
bdeec43
Compare
tqchen
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step in retiring the unused
ci_lintDocker image.This PR removes
ci_lintfrom the generated Jenkins Docker image matrix so new Jenkinsfiles no longer resolve, build, or deploy that image. It also skipsci_lintin the nightly Docker image updater and teachesgit_change_docker.shto ignore the lint Docker files that will be removed later.The actual lint Docker files are intentionally kept in this PR for compatibility with the current Jenkins PR bootstrap path. Some PR Docker jobs may still run the main-branch pipeline while reading files from the PR checkout, and that older pipeline still passes
ci_linttodetermine_docker_images.pyduring prepare. Keeping the files and the temporarydocker-images.inientry avoids failing before the updated generated Jenkinsfiles take effect.A follow-up PR can delete
docker/Dockerfile.ci_lint,docker/install/ubuntu_install_clang_format.sh,docker/lint.sh, and the README lint Docker example after this lands.