Skip to content

ZOOKEEPER-4924: change double "the" word into one#2251

Merged
tisonkun merged 1 commit intoapache:masterfrom
SSSDNSY:master
Apr 30, 2025
Merged

ZOOKEEPER-4924: change double "the" word into one#2251
tisonkun merged 1 commit intoapache:masterfrom
SSSDNSY:master

Conversation

@SSSDNSY
Copy link
Copy Markdown
Contributor

@SSSDNSY SSSDNSY commented Apr 27, 2025

No description provided.

Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@SSSDNSY
Copy link
Copy Markdown
Contributor Author

SSSDNSY commented Apr 28, 2025

Thank you! LGTM.

谢谢大佬帮忙PR,也在看佬的博客,向您学习!
Thank you for helping with PR, I am also reading your blog and learning from you!

@tisonkun tisonkun requested review from anmolnar and kezhuw April 29, 2025 00:14
@tisonkun
Copy link
Copy Markdown
Member

@SSSDNSY Never mind.

I noticed that previous typo fixes are associated with a JIRA ticket also - https://issues.apache.org/jira/browse/ZOOKEEPER-4877 & #2203

Would you create a ticket and update the PR title to ZOOKEEPER-<ticket_number>?

@SSSDNSY
Copy link
Copy Markdown
Contributor Author

SSSDNSY commented Apr 30, 2025

@SSSDNSY Never mind.

I noticed that previous typo fixes are associated with a JIRA ticket also - https://issues.apache.org/jira/browse/ZOOKEEPER-4877 & #2203

Would you create a ticket and update the PR title to ZOOKEEPER-<ticket_number>?

yes ,I 'm happy to do as your say , thank you JIRA URL 。

@SSSDNSY
Copy link
Copy Markdown
Contributor Author

SSSDNSY commented Apr 30, 2025

@SSSDNSY Never mind.

I noticed that previous typo fixes are associated with a JIRA ticket also - https://issues.apache.org/jira/browse/ZOOKEEPER-4877 & #2203

Would you create a ticket and update the PR title to ZOOKEEPER-<ticket_number>?

As a newcomer, I may have done things incorrectly. I will follow the steps below to improve my PR repair:

  1. Register JIRA
  2. Propose a new ISSUE
  3. Modify PR title

@SSSDNSY
Copy link
Copy Markdown
Contributor Author

SSSDNSY commented Apr 30, 2025

@SSSDNSY Never mind.

I noticed that previous typo fixes are associated with a JIRA ticket also - https://issues.apache.org/jira/browse/ZOOKEEPER-4877 & #2203

Would you create a ticket and update the PR title to ZOOKEEPER-<ticket_number>?

I have already submitted a new ISSUE on JIRA and modified the current PR title :)

@SSSDNSY SSSDNSY changed the title fix: change double "the" word into one ZOOKEEPER-4924: change double "the" word into one Apr 30, 2025
@tisonkun
Copy link
Copy Markdown
Member

tisonkun commented Apr 30, 2025

Thanks! Merging ...

@tisonkun tisonkun merged commit bf71704 into apache:master Apr 30, 2025
16 checks passed
@SSSDNSY
Copy link
Copy Markdown
Contributor Author

SSSDNSY commented May 6, 2025

Excuse me, How can I find the "good first issue" or "beginner" in https://issues.apache.org/jira/projects/ZOOKEEPER , I use the jira filters but there no such tag word to filter issue. Could you give me some advice ,thank you much! @tisonkun

meszinorbi pushed a commit to meszinorbi/zookeeper-up that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants