Skip to content

ZOOKEEPER-4923: Add timeout to control brand-new session establishment#2253

Merged
anmolnar merged 1 commit intoapache:masterfrom
kezhuw:ZOOKEEPER-4923-brand-new-session-timeout-control
Dec 15, 2025
Merged

ZOOKEEPER-4923: Add timeout to control brand-new session establishment#2253
anmolnar merged 1 commit intoapache:masterfrom
kezhuw:ZOOKEEPER-4923-brand-new-session-timeout-control

Conversation

@kezhuw
Copy link
Copy Markdown
Member

@kezhuw kezhuw commented Apr 29, 2025 •
edited
Loading

@kezhuw kezhuw mentioned this pull request Apr 29, 2025
Merged
@kezhuw
Copy link
Copy Markdown
Member Author

kezhuw commented Apr 29, 2025

This is the master version of #2252.

@kezhuw kezhuw force-pushed the ZOOKEEPER-4923-brand-new-session-timeout-control branch from 7f069be to 8f6ed6b Compare June 23, 2025 08:06
@kezhuw kezhuw force-pushed the ZOOKEEPER-4923-brand-new-session-timeout-control branch 4 times, most recently from cfb2f5d to 94b2ec4 Compare July 27, 2025 12:57
anmolnar
anmolnar approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Don't you wanna make it configurable?

@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Dec 12, 2025

Needing this patch means that ZOOKEEPER-4921 has never been fixed on master. We have a separate ticket now dedicated for the master branch ZOOKEEPER-4923. Is that correct @kezhuw ?

cnauroth
cnauroth approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @kezhuw .

@kezhuw
Copy link
Copy Markdown
Member Author

kezhuw commented Dec 14, 2025

Needing this patch means that ZOOKEEPER-4921 has never been fixed on master. We have a separate ticket now dedicated for the master branch ZOOKEEPER-4923. Is that correct @kezhuw ?

I cherry-picked ZOOKEEPER-4921(#2252) to master in 5b4be58. Here is the commit message:

This is cherry picked from commit 0971e5e
which is already merged to branch-3.9, this way we make ZOOKEEPER-4923 a
pure feature request.

ZOOKEEPER-4923 is indeed dedicated for master.

@kezhuw kezhuw force-pushed the ZOOKEEPER-4923-brand-new-session-timeout-control branch from 94b2ec4 to d0397cf Compare December 14, 2025 16:00
anmolnar
anmolnar approved these changes Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the clarification.

@anmolnar anmolnar merged commit 1c903df into apache:master Dec 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnauroth cnauroth cnauroth approved these changes

@anmolnar anmolnar anmolnar approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kezhuw @anmolnar @cnauroth