Skip to content

ZOOKEEPER-4928: Fix ZOO_VERSION not updated during mvn release:prepare#2259

Merged
kezhuw merged 1 commit intoapache:masterfrom
kezhuw:ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release
May 12, 2025
Merged

ZOOKEEPER-4928: Fix ZOO_VERSION not updated during mvn release:prepare#2259
kezhuw merged 1 commit intoapache:masterfrom
kezhuw:ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release

Conversation

@kezhuw
Copy link
Copy Markdown
Member

@kezhuw kezhuw commented May 11, 2025

No description provided.

@kezhuw
Copy link
Copy Markdown
Member Author

kezhuw commented May 11, 2025

I verified this using mvn release:prepare -Pfull-build according to https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven+release+plugin.

Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Thanks

Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kezhuw kezhuw merged commit aeadf57 into apache:master May 12, 2025
15 of 16 checks passed
@kezhuw kezhuw deleted the ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release branch May 12, 2025 01:23
kezhuw added a commit that referenced this pull request May 12, 2025
Reviewers: eolivelli, tisonkun
Author: kezhuw
Closes #2259 from kezhuw/ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release

(cherry picked from commit aeadf57)
Signed-off-by: Kezhu Wang <kezhuw@apache.org>
kezhuw added a commit that referenced this pull request May 12, 2025
Reviewers: eolivelli, tisonkun
Author: kezhuw
Closes #2259 from kezhuw/ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release

(cherry picked from commit aeadf57)
Signed-off-by: Kezhu Wang <kezhuw@apache.org>
@kezhuw
Copy link
Copy Markdown
Member Author

kezhuw commented May 12, 2025

Thank you for reviewing!

I have merged and backported this to master, branch-3.9(adc8744 with ZOO_VERSION in zookeeper_version.h bumped) and branch-3.8(56cc908).

@tisonkun I marked ZOOKEEPER-4928 also fixed in 3.9.4 as it supposed to be included in that version. I planed to create a pr for branch-3.9.4, but it is versioned as 3.9.5-SNAPSHOT currently. I am going to leave 3.9.4 backport to you so to avoid conflict.

kezhuw added a commit to kezhuw/zookeeper that referenced this pull request Jun 3, 2025
Reviewers: eolivelli, tisonkun
Author: kezhuw
Closes apache#2259 from kezhuw/ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release
@kezhuw
Copy link
Copy Markdown
Member Author

kezhuw commented Jun 5, 2025

I have moved the fixVersion from 3.9.4 to 3.9.5 to reflect the backport facts for now. cc @tisonkun

meszinorbi pushed a commit to meszinorbi/zookeeper-up that referenced this pull request Dec 10, 2025
Reviewers: eolivelli, tisonkun
Author: kezhuw
Closes apache#2259 from kezhuw/ZOOKEEPER-4928-fix-ZOO_VERSION-not-updated-during-release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants