ZOOKEEPER-4997: Unify construction of TrustManager to dedicated method#2340
Merged
anmolnar merged 3 commits intoapache:masterfrom Dec 16, 2025
Merged
Conversation
Previously, there are three places having similar codes to construct `TrustManager`: 1. `ClientX509Util::getTrustManager` 2. `X509Util::createSSLContextAndOptionsFromConfig` 3. `X509AuthenticationProvider` This commit unifies them to one method.
anmolnar
requested changes
Dec 15, 2025
Contributor
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
Please check the unit test failures. They have failed in two distinct builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there are three places having similar codes to construct
TrustManager:ClientX509Util::getTrustManagerX509Util::createSSLContextAndOptionsFromConfigX509AuthenticationProviderThis commit unifies them to one method.