ZOOKEEPER-5061 ZooKeeper website fixes#2413
Conversation
|
Added a few more changes. |
| // | ||
|
|
||
| export const CURRENT_VERSION = "3.9.5"; | ||
| export const CURRENT_VERSION = "3.9.10"; |
There was a problem hiding this comment.
Since we're on the master branch this should be 3.10.0
| function OlderDocsSubMenu() { | ||
| return ( | ||
| <DropdownMenuSub> | ||
| <DropdownMenuSubTrigger>Older docs</DropdownMenuSubTrigger> | ||
| <DropdownMenuSubContent className="w-56 p-0"> | ||
| <OlderDocsVersionList /> | ||
| </DropdownMenuSubContent> | ||
| </DropdownMenuSub> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Please don't remove the Older Docs section. We still need it for all the legacy docs: 3.3.x, 3.4.x, 3.5.x and everything else.
|
I think the "IRC Channel" page could be replaced with ASF Slack information, because IRC is no longer maintained. Workspace: https://the-asf.slack.com/ |
|
Tests with Ignore that. You already listed the supported Node versions in the Readme. 👍 |
phunt
left a comment
phunt
left a comment
There was a problem hiding this comment.
lgtm - the issue of http->https is a good fix. we should do this across the codebase (separate jira/pr)
|
|
||
| Full documentation for this release can also be found in ../../docs/index.html | ||
| Full documentation for this release can also be found at: | ||
| https://zookeeper.apache.org/doc/current/ |
There was a problem hiding this comment.
I'm not sure - but shouldn't all references be local given the doc relative to this reference is in this code base and should be used (could be updated as part of a change) rather than pointing to the release version on the website? Similar comment for all the relative -> absolute/web conversions in this commit.
3 participants
Here are the website fixes to issues/bugs addressed by @phunt and @anmolnar
I also added an updated
README.mdfile to this PR, so it's easier to review for everyone. Once the PR is approved, I will remove it and @anmolnar will update the wiki page. The file describes how the update and release flows of the website happen. I tried to write in as much detail as possible.Thanks.