refactor: remove all deep imports in language service

Removes all deep imports, which cause problems with vitest module resolution

Author: atscott

packages/compiler-cli/BUILD.bazel

@@ -82,14 +82,17 @@ ts_project(
         "//:node_modules/typescript",
         "//packages/compiler",
         "//packages/compiler-cli/private",
+        "//packages/compiler-cli/src/ngtsc/annotations",
         "//packages/compiler-cli/src/ngtsc/core",
         "//packages/compiler-cli/src/ngtsc/core:api",
         "//packages/compiler-cli/src/ngtsc/diagnostics",
         "//packages/compiler-cli/src/ngtsc/docs",
         "//packages/compiler-cli/src/ngtsc/file_system",
+        "//packages/compiler-cli/src/ngtsc/imports",
         "//packages/compiler-cli/src/ngtsc/incremental",
         "//packages/compiler-cli/src/ngtsc/indexer",
         "//packages/compiler-cli/src/ngtsc/logging",
+        "//packages/compiler-cli/src/ngtsc/metadata",
         "//packages/compiler-cli/src/ngtsc/perf",
         "//packages/compiler-cli/src/ngtsc/program_driver",
         "//packages/compiler-cli/src/ngtsc/reflection",

packages/compiler-cli/index.ts

@@ -33,15 +33,55 @@ export {NgTscPlugin, PluginCompilerHost} from './src/ngtsc/tsc_plugin';
 export {NgtscProgram} from './src/ngtsc/program';
 export {OptimizeFor} from './src/ngtsc/typecheck/api';
 
+// Explicit exports for language service
+export {getAngularDecorators} from './src/ngtsc/annotations';
+export {
+  NgCompiler,
+  type NgCompilerOptions,
+  type CompilationTicket,
+  freshCompilationTicket,
+  incrementalFromCompilerTicket,
+  resourceChangeTicket,
+} from './src/ngtsc/core';
+export {type NgCompilerAdapter} from './src/ngtsc/core/api';
+export {Reference} from './src/ngtsc/imports';
+export {
+  type DirectiveMeta,
+  type InputMapping,
+  isExternalResource,
+  MetaKind,
+  type PipeMeta,
+  type Resource,
+} from './src/ngtsc/metadata';
+export {
+  type DeclarationNode,
+  isNamedClassDeclaration,
+  type ReflectionHost,
+  type ClassDeclaration,
+} from './src/ngtsc/reflection';
+export {isFatalDiagnosticError} from './src/ngtsc/diagnostics';
+export {PerfPhase} from './src/ngtsc/perf';
+export {type FileUpdate, type ProgramDriver} from './src/ngtsc/program_driver';
+export {TrackedIncrementalBuildStrategy} from './src/ngtsc/incremental';
+export {isShim} from './src/ngtsc/shims';
+export {getRootDirs} from './src/ngtsc/util/src/typescript';
+export * from './src/ngtsc/typecheck/api';
+
 // **Note**: Explicit named exports to make this file work with CJS/ESM interop without
 // needing to use a default import. NodeJS will expose named CJS exports as named ESM exports.
 // TODO(devversion): Remove these duplicate exports once devmode&prodmode is combined/ESM.
 export {ConsoleLogger, Logger, LogLevel} from './src/ngtsc/logging';
 export {
   NodeJSFileSystem,
   absoluteFrom,
-  FileSystem,
-  AbsoluteFsPath,
+  absoluteFromSourceFile,
+  resolve,
+  type FileStats,
+  type PathSegment,
+  type PathString,
+  getSourceFileOrError,
+  type FileSystem,
+  type AbsoluteFsPath,
   NgtscCompilerHost,
   getFileSystem,
   setFileSystem,

packages/language-service/src/adapters.ts

@@ -8,16 +8,17 @@
 
 /** @fileoverview provides adapters for communicating with the ng compiler */
 
-import {ConfigurationHost} from '@angular/compiler-cli';
-import {NgCompilerAdapter} from '@angular/compiler-cli/src/ngtsc/core/api';
 import {
   AbsoluteFsPath,
+  ConfigurationHost,
   FileStats,
+  NgCompilerAdapter,
   PathSegment,
   PathString,
-} from '@angular/compiler-cli/src/ngtsc/file_system';
-import {isShim} from '@angular/compiler-cli/src/ngtsc/shims';
-import {getRootDirs} from '@angular/compiler-cli/src/ngtsc/util/src/typescript';
+  getRootDirs,
+  isShim,
+} from '@angular/compiler-cli';
+
 import * as p from 'path';
 import ts from 'typescript';
 

packages/language-service/src/attribute_completions.ts

@@ -19,7 +19,7 @@ import {
   TemplateSymbol,
   TemplateTypeChecker,
   TypeCheckableDirectiveMeta,
-} from '@angular/compiler-cli/src/ngtsc/typecheck/api';
+} from '@angular/compiler-cli';
 import ts from 'typescript';
 
 import {DisplayInfoKind, unsafeCastDisplayInfoKindToScriptElementKind} from './utils/display_parts';

packages/language-service/src/codefixes/code_fixes.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {NgCompiler} from '@angular/compiler-cli/src/ngtsc/core';
+import {NgCompiler} from '@angular/compiler-cli';
 import type ts from 'typescript';
 
 import {TypeCheckInfo} from '../utils';

packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts

@@ -7,7 +7,7 @@
  */
 
 import {TmplAstBoundEvent} from '@angular/compiler';
-import {ErrorCode, ngErrorCode} from '@angular/compiler-cli/src/ngtsc/diagnostics';
+import {ErrorCode, ngErrorCode} from '@angular/compiler-cli';
 import type ts from 'typescript';
 
 import {getTargetAtPosition, TargetNodeKind} from '../template_target';

packages/language-service/src/codefixes/fix_missing_import.ts

@@ -7,8 +7,13 @@
  */
 
 import {ASTWithName, TmplAstElement} from '@angular/compiler';
-import {ErrorCode as NgCompilerErrorCode, ngErrorCode} from '@angular/compiler-cli';
-import {PotentialDirective, PotentialPipe} from '@angular/compiler-cli/src/ngtsc/typecheck/api';
+import {
+  ErrorCode as NgCompilerErrorCode,
+  ngErrorCode,
+  PotentialDirective,
+  PotentialPipe,
+} from '@angular/compiler-cli';
+
 import type ts from 'typescript';
 
 import {getTargetAtPosition, TargetNodeKind} from '../template_target';

packages/language-service/src/codefixes/fix_missing_required_inputs.ts

@@ -14,8 +14,13 @@ import {
   TmplAstTemplate,
   TmplAstTextAttribute,
 } from '@angular/compiler';
-import {ErrorCode, ngErrorCode} from '@angular/compiler-cli/src/ngtsc/diagnostics';
-import {TypeCheckableDirectiveMeta} from '@angular/compiler-cli/src/ngtsc/typecheck/api';
+import {
+  ErrorCode,
+  InputMapping,
+  ngErrorCode,
+  TypeCheckableDirectiveMeta,
+} from '@angular/compiler-cli';
+
 import ts from 'typescript';
 
 import {getTargetAtPosition, TargetNodeKind} from '../template_target';
@@ -168,7 +173,7 @@ function getBoundAttributes(
     if (inputs !== null) {
       boundInputs.push({
         attribute: attr,
-        inputs: inputs.map((input) => ({
+        inputs: inputs.map((input: InputMapping) => ({
           fieldName: input.classPropertyName,
           required: input.required,
         })),

packages/language-service/src/codefixes/fix_unused_standalone_imports.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {ErrorCode, ngErrorCode} from '@angular/compiler-cli/src/ngtsc/diagnostics';
+import {ErrorCode, ngErrorCode} from '@angular/compiler-cli';
 import tss from 'typescript';
 
 import {CodeActionMeta, FixIdForCodeFixesAll} from './utils';

packages/language-service/src/codefixes/utils.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {absoluteFrom} from '@angular/compiler-cli';
-import {NgCompiler} from '@angular/compiler-cli/src/ngtsc/core';
+import {NgCompiler, absoluteFrom} from '@angular/compiler-cli';
+
 import type ts from 'typescript';
 
 import {TypeCheckInfo} from '../utils';