Skip to content

Commit 3b6ed53

Browse files
authored
chore(rerank): remove final config leftovers
Remove final rerank deploy/env leftovers and stale schema shim comments.
1 parent 1bfa790 commit 3b6ed53

4 files changed

Lines changed: 11 additions & 15 deletions

File tree

aperag/schema/view_models.py

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@
2222

2323
from pydantic import BaseModel, ConfigDict, Field, RootModel, conint
2424

25+
# Forward ref resolution for the local ``ChatSuccessResponse`` class
26+
# below; ``ChatMessage`` itself lives in the conversation domain after
27+
# Phase 5 step 5-S3. Imported here at module top so the Pydantic class
28+
# body at line ~622 resolves the annotation without needing the
29+
# (now-stripped) end-of-file dual-hook block.
30+
from aperag.domains.conversation.schemas import ChatMessage # noqa: F401
31+
2532
# Phase 3 Step 4b (msg=1505044c): shared primitives moved to
2633
# `aperag.schema.common` so the `knowledge_base` domain can depend on
2734
# them without tripping Phase 3 G1 (``aperag.schema.view_models`` is on
@@ -37,13 +44,6 @@
3744
VisionChunk,
3845
)
3946

40-
# Forward ref resolution for the local ``ChatSuccessResponse`` class
41-
# below; ``ChatMessage`` itself lives in the conversation domain after
42-
# Phase 5 step 5-S3. Imported here at module top so the Pydantic class
43-
# body at line ~622 resolves the annotation without needing the
44-
# (now-stripped) end-of-file dual-hook block.
45-
from aperag.domains.conversation.schemas import ChatMessage # noqa: F401
46-
4747

4848
class FailResponse(BaseModel):
4949
code: Optional[str] = Field(None, description="Error code", examples=["400"])
@@ -320,8 +320,7 @@ class NodeMergeResponse(BaseModel):
320320
# LlmProviderModelList / LlmProviderModelCreate /
321321
# LlmProviderModelCreateRequest / LlmProviderModelUpdate /
322322
# EmbeddingRequest / EmbeddingData / EmbeddingUsage / EmbeddingResponse /
323-
# Document1 / RerankRequest / Document2 / RerankDocument / RerankUsage /
324-
# RerankResponse moved to ``aperag.domains.model_platform.schemas``
323+
# Document1 / Document2 moved to ``aperag.domains.model_platform.schemas``
325324
# in Phase 4 Step 4-S3d; end-of-file try block re-imports them.
326325

327326

@@ -563,9 +562,6 @@ class EvaluationChatWithAgentResponse(RootModel[Union[ChatSuccessResponse, Agent
563562
# directly from the canonical modules; consumers outside
564563
# ``aperag/domains/**`` may continue to use either path during the
565564
# transition window.
566-
from aperag.domains.knowledge_base.schemas import ( # noqa: E402,F401
567-
ExportTaskResponse,
568-
)
569565
from aperag.domains.governance.schemas import ( # noqa: E402,F401
570566
QuotaInfo,
571567
QuotaUpdateRequest,
@@ -578,6 +574,9 @@ class EvaluationChatWithAgentResponse(RootModel[Union[ChatSuccessResponse, Agent
578574
UserQuotaInfo,
579575
UserQuotaList,
580576
)
577+
from aperag.domains.knowledge_base.schemas import ( # noqa: E402,F401
578+
ExportTaskResponse,
579+
)
581580
from aperag.domains.knowledge_graph.schemas import ( # noqa: E402,F401
582581
GraphCurationRunSummary,
583582
GraphEdge,

deploy/aperag/templates/aperag-secret.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ stringData:
117117
CACHE_REDIS_URL={{ .Values.api.env.CACHE_REDIS_URL }}
118118
CACHE_LLM_TTL_SECONDS={{ .Values.api.env.CACHE_LLM_TTL_SECONDS }}
119119
CACHE_EMBEDDING_TTL_SECONDS={{ .Values.api.env.CACHE_EMBEDDING_TTL_SECONDS }}
120-
CACHE_RERANK_TTL_SECONDS={{ .Values.api.env.CACHE_RERANK_TTL_SECONDS }}
121120
CACHE_WEB_SEARCH_TTL_SECONDS={{ .Values.api.env.CACHE_WEB_SEARCH_TTL_SECONDS }}
122121
CACHE_WEB_READ_TTL_SECONDS={{ .Values.api.env.CACHE_WEB_READ_TTL_SECONDS }}
123122
CACHE_PARSER_PREFLIGHT_TTL_SECONDS={{ .Values.api.env.CACHE_PARSER_PREFLIGHT_TTL_SECONDS }}

deploy/aperag/values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ api:
240240
CACHE_REDIS_URL: ""
241241
CACHE_LLM_TTL_SECONDS: ""
242242
CACHE_EMBEDDING_TTL_SECONDS: ""
243-
CACHE_RERANK_TTL_SECONDS: ""
244243
CACHE_WEB_SEARCH_TTL_SECONDS: "600"
245244
CACHE_WEB_READ_TTL_SECONDS: "3600"
246245
CACHE_PARSER_PREFLIGHT_TTL_SECONDS: "60"

envs/env.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ CACHE_TTL=86400
205205
CACHE_REDIS_URL=
206206
CACHE_LLM_TTL_SECONDS=
207207
CACHE_EMBEDDING_TTL_SECONDS=
208-
CACHE_RERANK_TTL_SECONDS=
209208
CACHE_WEB_SEARCH_TTL_SECONDS=600
210209
CACHE_WEB_READ_TTL_SECONDS=3600
211210
CACHE_PARSER_PREFLIGHT_TTL_SECONDS=60

0 commit comments

Comments
 (0)